PathSource::list_files doesn't look at .gitignore if there's no package in the git root #1729
Comments
|
Also note that there is a comment to this effect, it just turned out to be correct! |
metajack
added a commit
to metajack/servo
that referenced
this issue
Jun 17, 2015
This is necessary to ensure Cargo knows when to rebuild. Normally .gitignore would be enough to exclude these from Cargo's freshness calculation, but rust-lang/cargo#1729 prevents this currently. This is the new, correct way to do these thigns, just like the style crate does.
metajack
added a commit
to metajack/servo
that referenced
this issue
Jun 17, 2015
This is necessary to ensure Cargo knows when to rebuild. Normally .gitignore would be enough to exclude these from Cargo's freshness calculation, but rust-lang/cargo#1729 prevents this currently. This is the new, correct way to do these thigns, just like the style crate does.
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Jun 17, 2015
Generate code into OUT_DIR. This is necessary to ensure Cargo knows when to rebuild. Normally .gitignore would be enough to exclude these from Cargo's freshness calculation, but rust-lang/cargo#1729 prevents this currently. This is the new, correct way to do these thigns, just like the style crate does. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6408) <!-- Reviewable:end -->
jrmuizel
pushed a commit
to jrmuizel/gecko-cinnabar
that referenced
this issue
Jun 12, 2017
…-outdir); r=SimonSapin This is necessary to ensure Cargo knows when to rebuild. Normally .gitignore would be enough to exclude these from Cargo's freshness calculation, but rust-lang/cargo#1729 prevents this currently. This is the new, correct way to do these thigns, just like the style crate does. Source-Repo: https://github.com/servo/servo Source-Revision: ff59e1b8de67f1988522d6b6e6c4adda957fad5b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Sep 30, 2019
…-outdir); r=SimonSapin This is necessary to ensure Cargo knows when to rebuild. Normally .gitignore would be enough to exclude these from Cargo's freshness calculation, but rust-lang/cargo#1729 prevents this currently. This is the new, correct way to do these thigns, just like the style crate does. Source-Repo: https://github.com/servo/servo Source-Revision: ff59e1b8de67f1988522d6b6e6c4adda957fad5b UltraBlame original commit: b4e57a840c0b24a7bbc5db12f6d91b40300761f2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Oct 1, 2019
…-outdir); r=SimonSapin This is necessary to ensure Cargo knows when to rebuild. Normally .gitignore would be enough to exclude these from Cargo's freshness calculation, but rust-lang/cargo#1729 prevents this currently. This is the new, correct way to do these thigns, just like the style crate does. Source-Repo: https://github.com/servo/servo Source-Revision: ff59e1b8de67f1988522d6b6e6c4adda957fad5b UltraBlame original commit: b4e57a840c0b24a7bbc5db12f6d91b40300761f2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Oct 1, 2019
…-outdir); r=SimonSapin This is necessary to ensure Cargo knows when to rebuild. Normally .gitignore would be enough to exclude these from Cargo's freshness calculation, but rust-lang/cargo#1729 prevents this currently. This is the new, correct way to do these thigns, just like the style crate does. Source-Repo: https://github.com/servo/servo Source-Revision: ff59e1b8de67f1988522d6b6e6c4adda957fad5b UltraBlame original commit: b4e57a840c0b24a7bbc5db12f6d91b40300761f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently
PathSource::list_fileslooks for packages whereRepository::openwill succeed, but this will never succeed if there is never a package at the root of a git repository. This means that filters such as pruning everything in.gitignorefrom the file listings will not work because no git repository is detected.To replicate this behavior:
cargo new acargo new bbto depend ona(as a path dependency)ato have a build script which creates the filea/fooin the git repositorya/footo the repo's.gitignoreOn re-running
cargo buildin the directory forbit will spuriously rebuildatoo frequently as it doesn't know that it should ignorea/foo.The text was updated successfully, but these errors were encountered: