Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support comma-separation of features #3360

Closed
dhardy opened this issue Dec 2, 2016 · 2 comments
Closed

Support comma-separation of features #3360

dhardy opened this issue Dec 2, 2016 · 2 comments
Labels
A-features Area: features — conditional compilation

Comments

@dhardy
Copy link

dhardy commented Dec 2, 2016 

$ cargo test --features=use-mock-crust,clippy
error: Package `routing v0.25.1 [...]` does not have these features: `use-mock-crust,clippy`

Please don't tell me a comma is a valid part of a feature name. Cargo should split on comma to enable --features=a,b,c as well as --features="a b c".
@alexcrichton alexcrichton added the A-features Area: features — conditional compilation label Dec 2, 2016
@shiver shiver mentioned this issue May 22, 2017
Merged
bors added a commit that referenced this issue May 22, 2017
@bors
Auto merge of #4084 - shiver:issue-3360, r=alexcrichton
26d1d9d 
3360 - Allow for features to be either comma or space delimited.

This is my attempt at tackling issue #3360.
Hopefully I interpreted the original request correctly and this is what you were looking for.

Any suggestions you might have to improve the submission would be great.
Thanks!
@aochagavia
Copy link
Contributor

aochagavia commented May 24, 2017 •
edited
Loading

This should probably be closed now (see #4084)

@alexcrichton
Copy link
Member

Indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-features Area: features — conditional compilation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @dhardy @aochagavia