Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspaces: All building all members of the workspace #3491

Closed
sdroege opened this issue Jan 4, 2017 · 10 comments
Closed

workspaces: All building all members of the workspace #3491

sdroege opened this issue Jan 4, 2017 · 10 comments
Labels
E-easy Experience: Easy

Comments

@sdroege
Copy link
Contributor

sdroege commented Jan 4, 2017

Something like "cargo build" in the root of the workspace would seem useful, which would then build all members of the workspace. Similar to how "cargo clean" currently cleans the workspace.

@steveklabnik
Copy link
Member

steveklabnik commented Jan 4, 2017

This should be --all, in my understanding

@alexcrichton
Copy link
Member

Yeah we've got cargo test --all now on Nightly so it should be easy enough to add cargo build --all!

@alexcrichton alexcrichton added the E-easy Experience: Easy label Jan 6, 2017
@sdroege
Copy link
Contributor Author

sdroege commented Jan 6, 2017

Basically something similar to 62c0497 then, just doing the same for build? Are there any other commands that could use some --all'ification?
I might take a look into that later, would be nice to replace my Makefile doing just that with a cargo command

@alexcrichton
Copy link
Member

Now that all of the support was landed with cargo test --all it may just involve copying these lines into build.rs. We could add cargo doc as well, although I'd want to just tread purposefully here to ensure we don't expand it too quickly

@sdroege
Copy link
Contributor Author

sdroege commented Jan 6, 2017

Thanks, it was almost just that (I've submitted a pull request). For "cargo doc" a little bit more is needed, but if you think that's useful to have (it seems useful to me), I can prepare a pull request for that too.

@alexcrichton
Copy link
Member

cargo doc --all sounds great to me! I'm sure it'll be requested sooner rather than later :)

@sdroege
Copy link
Contributor Author

sdroege commented Jan 7, 2017

Ok, I'll get to that once "build --all" is ready to be merged

bors added a commit that referenced this issue Jan 9, 2017
Add support for building all members of the workspace with "build --all"

#3491
@frewsxcv
Copy link
Member

frewsxcv commented Jan 9, 2017

Can this be closed now?

@frewsxcv
Copy link
Member

frewsxcv commented Jan 9, 2017

Should the default Travis CI Rust script use --all by default once this lands in stable?

@sdroege
Copy link
Contributor Author

sdroege commented Jan 9, 2017

I would wait until #3515 landed before closing

bors added a commit that referenced this issue Jan 9, 2017
 Add support for documenting all members of the workspace with "doc --all"

#3491
@sdroege sdroege closed this as completed Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Experience: Easy
Projects
None yet
Development

No branches or pull requests

4 participants