Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path and registry shouldn't be mutually exclusive in dependency configurations #4843

Closed
sfackler opened this issue Dec 21, 2017 · 2 comments · Fixed by #4844
Closed

path and registry shouldn't be mutually exclusive in dependency configurations #4843

sfackler opened this issue Dec 21, 2017 · 2 comments · Fixed by #4844

Comments

@sfackler
Copy link
Member

In multi-crate workspaces, dependencies to other crates in the workspace are specified with path when building locally, as well as version when the crate is pulled from a registry. If registry can't be used with path, then multi-crate workspaces that publish to a custom registry don't work.

cc @withoutboats
@sfackler
Copy link
Member Author

The check is made here:

cargo/src/cargo/util/toml/mod.rs

Line 930 in 868d373

(_, Some(_), Some(_)) => bail!("dependency ({}) specification is ambiguous. \

@sfackler
Copy link
Member Author

Simply removing that restriction causes the registry field in the index entry to be the file path. It seems like the logic in #4568 is not quite right. The source ID of the dependency is going to be a file path here, which isn't right. cc @cswindle

@sfackler sfackler mentioned this issue Dec 21, 2017
Merged
@aturon aturon mentioned this issue Jan 8, 2018
Closed
11 tasks
sfackler added a commit to sfackler/cargo that referenced this issue Jan 20, 2018
@sfackler
Allow path + registry dependencies
0ec7f68 
Closes rust-lang#4843
bors added a commit that referenced this issue Jan 20, 2018
@bors
Auto merge of #4844 - sfackler:path-registry-okay, r=alexcrichton
7f3196d 
Allow path + registry dependencies

Closes #4843

Do we have any infrastructure for testing what metadata a publish actually sends to the registry?

r? @withoutboats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow path + registry dependencies sfackler/cargo
1 participant
@sfackler