Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

progressbar refreshes unnecessarily? #5697

Closed
matthiaskrgr opened this issue Jul 8, 2018 · 1 comment · Fixed by #5698
Closed

progressbar refreshes unnecessarily? #5697

matthiaskrgr opened this issue Jul 8, 2018 · 1 comment · Fixed by #5698

Comments

@matthiaskrgr
Copy link
Member

When building servo I noticed that the progress bar seems to flicker (refresh?) a lot even when there is no actual change of its text/content.

Maybe we can do a string comparison and only update/write to stdout it if new status line =! old status line?

I use alacritty as terminal.
alexcrichton added a commit to alexcrichton/cargo that referenced this issue Jul 8, 2018
@alexcrichton
Disable progress bar for build in Cargo
0102387 
This is primarily blocked on rust-lang#5695 which unfortunately doesn't have a great fix
today, so disable it for now while we try to work out a better solution.

Closes rust-lang#5695
Closes rust-lang#5697
@alexcrichton alexcrichton mentioned this issue Jul 8, 2018
Merged
@Eh2406
Copy link
Contributor

Eh2406 commented Jul 9, 2018

Same hear with windows cmd. I was too lazy to report, so thanks @matthiaskrgr!

bors added a commit that referenced this issue Jul 9, 2018
@bors
Auto merge of #5698 - alexcrichton:no-progress-sad, r=kennytm
cc11d50 
Disable progress bar for build in Cargo

This is primarily blocked on #5695 which unfortunately doesn't have a great fix
today, so disable it for now while we try to work out a better solution.

Closes #5695
Closes #5697
@bors bors closed this as completed in #5698 Jul 9, 2018
kennytm added a commit to kennytm/cargo that referenced this issue Jul 12, 2018
@kennytm
Compile progress: Do not update when a build script prints something.
9612be6 
Fix rust-lang#5697. There may still be some little flickering, but should be much
less severe than before.
@kennytm kennytm mentioned this issue Jul 12, 2018
Merged
bors added a commit that referenced this issue Jul 12, 2018
@bors
Auto merge of #5716 - kennytm:unstable-compile-progress, r=alexcrichton
a5617df 
Reintroduce the compile progress bar as an unstable feature (-Z compile-progress)

This allows us to test the feature on-demand to see if there's any other bugs besides #5695.

Also, fixed the flickering #5697 (this was caused by build script emitting Stdout/Stderr events).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable progress bar for build in Cargo alexcrichton/cargo
2 participants
@matthiaskrgr @Eh2406