Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo fix still warns about rust_2018_preview #6050

Closed
steveklabnik opened this issue Sep 18, 2018 · 1 comment · Fixed by #6052
Closed

cargo fix still warns about rust_2018_preview #6050

steveklabnik opened this issue Sep 18, 2018 · 1 comment · Fixed by #6052

Comments

@steveklabnik
Copy link
Member

This flag is not supposed to be used for the beta release, but:

> > cargo fix --edition
    Checking foo v0.1.0 (C:\Users\steve\tmp\foo)
warning: failed to find `#![feature(rust_2018_preview)]` in `src\lib.rs`
this may cause `cargo fix` to not be able to fix all
issues in preparation for the 2018 edition
@steveklabnik
Copy link
Member Author

testing a PR for this right now

@steveklabnik steveklabnik mentioned this issue Sep 18, 2018
Merged
steveklabnik added a commit to steveklabnik/cargo that referenced this issue Sep 18, 2018
@steveklabnik
No longer warn about #![feature(rust_2018_preview)]
d277c84 
This is no longer needed, and so the warning is outdated.

Fixes rust-lang#6050
bors added a commit that referenced this issue Sep 18, 2018
@bors
Auto merge of #6052 - steveklabnik:gh6050, r=joshtriplett
93e3216 
No longer warn about #![feature(rust_2018_preview)]

This is no longer needed, and so the warning is outdated.

Fixes #6050
steveklabnik added a commit to steveklabnik/cargo that referenced this issue Sep 18, 2018
@steveklabnik
No longer warn about #![feature(rust_2018_preview)]
f27fcf9 
This is no longer needed, and so the warning is outdated.

Fixes rust-lang#6050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

No longer warn about #![feature(rust_2018_preview)] steveklabnik/cargo
1 participant
@steveklabnik