Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to package on FAT-family filesystems #6238

Closed
khionu opened this issue Oct 30, 2018 · 1 comment · Fixed by #6257
Closed

Failure to package on FAT-family filesystems #6238

khionu opened this issue Oct 30, 2018 · 1 comment · Fixed by #6257

Comments

@khionu
Copy link
Member

khionu commented Oct 30, 2018

Problem
Packaging on FAT-family filesystems fails on attempting to set the Modified Time.

Steps

  1. Run cargo package on a FAT32 or exFAT filesystem

Possible Solution(s)
Take advantage of the flag added here.

@alexcrichton
Copy link
Member

To add some more context, this started out as alexcrichton/filetime#30, went to alexcrichton/tar-rs#169, and culminated in alexcrichton/tar-rs@f442964.

The problem here is that not all filesystems allow configuring the mtime (for whatever reason), but Cargo tries to set the mtime of files when it extracts them from a tarball. Cargo doesn't actually really need to do that though, so it should be easy enough to simply call set_preserve_mtime(false) on tarball extraction

bors added a commit that referenced this issue Nov 5, 2018
Configure tar to not set mtime

This PR is fixes #6238. Currently uses a `patch` on `tar`, and should not be merged until `tar` makes a release containing the function `set_preserve_mtime`.
@bors bors closed this as completed in #6257 Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants