Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when [patch] section is being ignored because of workspaces #6248

Closed
jethrogb opened this issue Nov 1, 2018 · 0 comments · Fixed by #6276
Closed

Warn when [patch] section is being ignored because of workspaces #6248

jethrogb opened this issue Nov 1, 2018 · 0 comments · Fixed by #6276
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`

Comments

@jethrogb
Copy link
Contributor

jethrogb commented Nov 1, 2018 •
edited
Loading

Describe the problem you are trying to solve

When you add a [patch] section to a crate's Cargo.toml, this section is ignored if the crate is part of a workspace. The [patch] section should be added in the workspace's Cargo.toml instead.

Describe the solution you'd like

cargo should warn about this situation.
@alexcrichton alexcrichton added the C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` label Nov 1, 2018
@ehuss ehuss mentioned this issue Nov 7, 2018
Merged
bors added a commit that referenced this issue Nov 7, 2018
@bors
Auto merge of #6276 - ehuss:ws-unused, r=alexcrichton
237f86e 
Warn/err on some unused manifest keys in workspaces.

- Err on dependencies, features, target, badges in virtual root.
- Warn on replace/patch in members.

Closes #6248, Closes #4870, Closes #4947
@bors bors closed this as completed in #6276 Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Warn/err on some unused manifest keys in workspaces. ehuss/cargo
2 participants
@alexcrichton @jethrogb