Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo fix errors #6390

Closed
fu5ha opened this issue Dec 7, 2018 · 2 comments
Closed

Cargo fix errors #6390

fu5ha opened this issue Dec 7, 2018 · 2 comments

Comments

@fu5ha
Copy link

fu5ha commented Dec 7, 2018

Problem
Running cargo fix on rendy fails on two files. Asks to report but with full output.

Steps
Clone rustgd/rendy, run cargo fix.

Notes

Output of cargo version: cargo 1.31.0 (339d9f9 2018-11-16)

Full output: https://gist.github.com/termhn/f02fdee4b79563c47a1238a558a916aa

@ehuss
Copy link
Contributor

ehuss commented Dec 7, 2018

Thanks for the report. This looks to be due to a bad suggestion in the rust_2018_compatibility lints previously reported at rust-lang/rust#56327. You can remove the dyn keyword here and here to work around it, or not use the rust_2018_compatibility lints.

@fu5ha
Copy link
Author

fu5ha commented Dec 7, 2018

👍 After adding the edition = "2018" and re-running cargo fix, then compiling, I ended up needing to re-add those dyns to make it happy.

@fu5ha fu5ha closed this as completed Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants