Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crates.io rate limiting response display isn't ideal #6714

Open
carols10cents opened this issue Mar 3, 2019 · 0 comments
Open

Crates.io rate limiting response display isn't ideal #6714

carols10cents opened this issue Mar 3, 2019 · 0 comments
Labels
A-interacts-with-crates.io Area: interaction with registries C-bug Category: bug Command-publish S-needs-mentor Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing.

Comments

@carols10cents
Copy link
Member

Heeyyy, so we added rate limiting to the publish endpoint recently that returns a 429 if you exceed the rate limit. We neglected to ensure that cargo shows a nice error message that explains what happened, and right now the default error display cargo does isn't ideal.

This is totally our fault, and I plan on fixing this soon (but I wouldn't be sad if someone else got to this before I did ;)) Just wanted to file this here so I don't forget!
@carols10cents carols10cents added C-bug Category: bug A-interacts-with-crates.io Area: interaction with registries labels Mar 3, 2019
@carols10cents carols10cents mentioned this issue Mar 3, 2019
Closed
@matthewkmayer matthewkmayer mentioned this issue Nov 29, 2019
Closed
CPerezz added a commit to CPerezz/cargo that referenced this issue Jan 31, 2021
@CPerezz
Improve Crates.io rate limiting response display
d9b48df 
In rust-lang/crates.io#1596 it was added
a rate limit for crate publishing endpoint connections (10 components/min).
As is said in the PR. The strategy used allows to upload 10 components
first and then the ratio starts to be applied.
Now, if the rate is surpassed, crates.io returns a 429 HTTP response.

Cargo, tries to publish all of the workspace/crate components as fast
as possible (as we should expect) but when we have more than 10
components and we try to publish the 11th, usually a minute hasn't
passed yet and therefore we get a HTTP-429.

This made some users to experience confusing/not well explained error
messages as seen in rust-lang/crates.io#1643.

The limit got increased to 30 components/min. But who knows..

So this closes rust-lang#6714 while
a better solution is not found.
This was referenced Jan 31, 2021
Closed
Open
@epage epage added Command-publish S-needs-mentor Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing. labels Oct 31, 2023
@ijackson ijackson mentioned this issue Mar 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-interacts-with-crates.io Area: interaction with registries C-bug Category: bug Command-publish S-needs-mentor Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Crates.io rate limiting response display CPerezz/cargo
2 participants
@epage @carols10cents