-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler-artifact
message doesn't include WASM files for --example ...
builds
#6810
Labels
C-bug
Category: bug
Comments
Oops, looks like a simple fix. I'm going to review the code to see if there are other places where the same mistake was made. |
bors
added a commit
that referenced
this issue
Apr 2, 2019
Don't include metadata in wasm binary examples. This removes the metadata hash from wasm example binaries, and consequently also includes the `.wasm` files in the artifact JSON message. Closes #6810. I renamed a method and added a new one to maybe make things a little clearer. This cannot be easily tested (see #4973).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Hi all, when I build a binary with
--target wasm32-unknown-emscripten
, thecompiler-artifact
message includes the.js
and.wasm
files under thefilenames
property. However, when I build an example with--example ...
, only the.js
file appears in thecompiler-artifact
message.cargo-web
depends on thecompiler-artifacts
message to determine which files to serve for itscargo web start
command, but it seems no message fromcargo
provides references to the generated.wasm
files for example builds.Thanks for your time!
Steps
I'm currently experiencing this with the
cube
example ingfx
.Example output of building
cargo build --message-format json --target wasm32-unknown-emscripten --example cube
(this output is missing the.wasm
file):For comparison, I have copied it to the
src
directory ascube_example_as_bin
and added an entry to theCargo.toml
file:Example output of building
cargo build --message-format json --target wasm32-unknown-emscripten
(this output includes the.wasm
file):Possible Solution(s)
Notes
Output of
cargo version
:cargo 1.33.0 (f099fe94b 2019-02-12)
The text was updated successfully, but these errors were encountered: