Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can_not_mix_doc_tests_and_regular_tests test is failing #6887

Closed
ehuss opened this issue Apr 29, 2019 · 2 comments
Closed

can_not_mix_doc_tests_and_regular_tests test is failing #6887

ehuss opened this issue Apr 29, 2019 · 2 comments
Labels
A-testing-cargo-itself Area: cargo's tests C-bug Category: bug S-propose-close Status: A team member has nominated this for closing, pending further input from the team

Comments

@ehuss
Copy link
Contributor

ehuss commented Apr 29, 2019

The can_not_mix_doc_tests_and_regular_tests test has failed randomly a few times recently on Travis:

https://travis-ci.com/rust-lang/cargo/jobs/185086470 (#6749, 2019-03-14)
https://travis-ci.com/rust-lang/cargo/jobs/196095265 (#6884, 2019-04-28)

Both were x86_64-unknown-linux-gnu, one was on 1.34.1 and the other was 1.35.0-nightly (bc44841ad 2019-03-14).

I cannot reproduce this. I have tried running the test in a loop for hours and I can't get it to fail. The test is very basic, and I can't imagine how it is possibly failing. Essentially it does:

  1. cargo test
  2. cargo test --lib
  3. cargo test --doc ← This step fails because it rebuilds the library.

It may be unrelated, but this started after recent changes to fingerprints (#6720, #6734). The test was added 2018-09-16.
@ehuss ehuss added C-bug Category: bug A-testing-cargo-itself Area: cargo's tests labels Apr 29, 2019
@ehuss ehuss mentioned this issue Apr 29, 2019
Merged
bors added a commit that referenced this issue Apr 29, 2019
@bors
Auto merge of #6888 - ehuss:debug-can_not_mix_doc_tests_and_regular_t…
2c335f7 
…ests, r=alexcrichton

Attempt to debug a spurious test.

See #6887.  My hope is that if it fails, the log might include a clue on what is wrong.
@epage
Copy link
Contributor

epage commented Oct 31, 2023

@ehuss the test is enabled and I'm not seeing any talk of this failing lately. Can we close this?

@epage epage added the S-propose-close Status: A team member has nominated this for closing, pending further input from the team label Oct 31, 2023
@ehuss
Copy link
Contributor Author

ehuss commented Oct 31, 2023

Yea, I think it is fine to close.

@ehuss ehuss closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing-cargo-itself Area: cargo's tests C-bug Category: bug S-propose-close Status: A team member has nominated this for closing, pending further input from the team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ehuss @epage