Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo status line incorrectly says "+ debuginfo" #6948

Closed
brson opened this issue May 17, 2019 · 0 comments · Fixed by #6971
Closed

Cargo status line incorrectly says "+ debuginfo" #6948

brson opened this issue May 17, 2019 · 0 comments · Fixed by #6971
Labels
C-bug Category: bug

Comments

@brson
Copy link
Contributor

brson commented May 17, 2019 •
edited
Loading

When debug=false it says

brian@DESKTOP-UCV672I:~/dbgtest$ cargo build --release
    Finished release [optimized] target(s) in 0.06s

When debug=0 it says

    Finished release [optimized + debuginfo] target(s) in 0.06s

My understanding is that "0" and "false" both mean "no debuginfo", but cargo claims otherwise. Cargo also passes the -Cdebuginfo=0 flag to rustc when debug=0 and does not when debug=false. For consistency, and as a matter of defensiveness it seems like it should pass the flag anyway.
@brson brson added the C-bug Category: bug label May 17, 2019
@brson brson changed the title Cargo status line incorrectly says "+optimized" Cargo status line incorrectly says "+ debuginfo" May 17, 2019
@ehuss ehuss mentioned this issue May 20, 2019
Merged
bors added a commit that referenced this issue May 20, 2019
@bors
Auto merge of #6971 - ehuss:finished-0-debug, r=alexcrichton
719781b 
Set `Finished` line correctly for debug=0.

Don't say `+ debuginfo` if `debug = 0`.

Fixes #6948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set Finished line correctly for debug=0. ehuss/cargo
1 participant
@brson