Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failing on rust-1.41.0 #7714

Closed
Mark-Simulacrum opened this issue Dec 17, 2019 · 5 comments
Closed

CI failing on rust-1.41.0 #7714

Mark-Simulacrum opened this issue Dec 17, 2019 · 5 comments
Labels
C-bug Category: bug

Comments

@Mark-Simulacrum
Copy link
Member

https://dev.azure.com/rust-lang/473adcf1-6656-4c7e-9337-c393e7e0431c/_apis/build/builds/16115/logs/100

I suspect this is a result of the recent extern-private work but it's not entirely clear to me why the branch is failing (and master presumably isn't).

@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: bug label Dec 17, 2019
@ehuss
Copy link
Contributor

ehuss commented Dec 17, 2019

I can't tell from the link what the context is. Is this related to rust-lang/rust#67351?

That is a "nightly" test. Those should be disabled on rust-lang/rust via CARGO_TEST_DISABLE_NIGHTLY. This helps with making unstable changes that require updates on both side which are impossible to do in one PR.

@Mark-Simulacrum
Copy link
Member Author

From this build here.

@ehuss
Copy link
Contributor

ehuss commented Dec 17, 2019

Oh, sorry, I misunderstood. This is the rust-1.41.0 branch on cargo. Indeed it is quite common for the beta branch to get broken because of issues like this, thanks for the heads up! We often backport test changes, but in this case the change is quite large. It's a little unfortunate that the cargo update has taken more than a week to merge. I considered raising the priority, but I didn't think any of the changes really needed to get on beta, and there seemed to be a lot of contention for bors time.

I'll disable the test.

@Mark-Simulacrum
Copy link
Member Author

I agree it's a bit unfortunate -- we've been having CI trouble with Chocolatey as well which probably helps explain some of the slowness there.

bors added a commit that referenced this issue Dec 17, 2019
[beta] Disable test not forwards compatible to nightly.

The `--extern` flag format changed (see #7699).  The changes didn't make it into beta, so just disable this test.  This isn't immediately necessary, but will be helpful if we need to make any other changes on the 1.41 branch in the future.

Closes #7714
@ehuss
Copy link
Contributor

ehuss commented Dec 19, 2019

Fixed in #7716.

@ehuss ehuss closed this as completed Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

No branches or pull requests

2 participants