-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkgid spec confusion #7725
Comments
Oh dear that didn't exactly age well... I think though we've started using As for the proto business I think it's fine to basically remove that and make the docs match the current implementation. In any case, what I would propose:
|
Update pkgid-spec docs. The old docs for the pkgid spec weren't correct. Specs never supported abbreviated URLs or aliases for the index (like `crates.io`). This tries to correct that and add a little more detail. Part of #7725.
I'm proposing we close this. All that is left is considering more abbreviated forms. In the 5 years this has been open, no one has piped in about wanting some. Instead of tracking this as a speculated need, I'd recommend we wait until a user requests it. |
Sounds good! |
The documentation for the package id spec (https://doc.rust-lang.org/1.40.0/cargo/reference/pkgid-spec.html) does not seem to be correct in several ways.
cargo://
which is not a scheme Cargo understands anywhere.crates.io
as a host does not work. It looks like you can only give the full path to the index, likehttps://github.com/rust-lang/crates.io-index#bitflags:1.2.1
host/name
doesn't work. It looks like the matching code requires the entire scheme/host/path to match.The question is, what should we do? Should we just remove all the things that don't work from the documentation? Or should we try to enhance the parsing/matching code to work better.
crates.io
work as an alias forhttps://github.com/rust-lang/crates.io-index
?host/name
matchhost/path#name
?EDIT: #9188 and #9249 fixed the broken parts, but leaving this open to consider adding abbreviated forms.
The text was updated successfully, but these errors were encountered: