-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git transfers are slow on macos #7988
Labels
A-git
Area: anything dealing with git
A-networking
Area: networking issues, curl, etc.
C-bug
Category: bug
O-macos
OS: macOS
P-high
Priority: High
Comments
ehuss
added
C-bug
Category: bug
A-git
Area: anything dealing with git
O-macos
OS: macOS
A-networking
Area: networking issues, curl, etc.
P-high
Priority: High
labels
Mar 12, 2020
alexcrichton
added a commit
to alexcrichton/cargo
that referenced
this issue
Mar 13, 2020
Brings in rust-lang/git2-rs#527 Closes rust-lang#7466 Closes rust-lang#7988
bors
added a commit
that referenced
this issue
Mar 13, 2020
Bump libgit2 dependencies Brings in rust-lang/git2-rs#527 Closes #7466 Closes #7988
ehuss
pushed a commit
to ehuss/cargo
that referenced
this issue
Mar 16, 2020
Bump libgit2 dependencies Brings in rust-lang/git2-rs#527 Closes rust-lang#7466 Closes rust-lang#7988
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-git
Area: anything dealing with git
A-networking
Area: networking issues, curl, etc.
C-bug
Category: bug
O-macos
OS: macOS
P-high
Priority: High
Problem
Starting with nightly which includes #7939, I believe there is an issue where git fetches tend to be very slow on macos (repro on 10.14 and 10.15). I can't repro on Linux.
Fetching a relatively small repo like https://github.com/alexcrichton/bzip2-rs.git regularly takes about 1 minute for me, whereas previously it was about 2 seconds. It doesn't happen all the time, but the majority it does.
Attaching with a debugger it seemed to just be stuck in
socket_read
, however I have not investigated much.Switching to Cargo's git2 curl implementation fixes the issue (it fetches in less than a second). This can be easily triggered by setting HTTP_TIMEOUT=60.
Steps
cargo fetch
The text was updated successfully, but these errors were encountered: