-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.43.0 published with wrong version #7994
Comments
@Mark-Simulacrum what do we want to do?
I'm mostly doing stuff manually, which is probably the cause of my occasional errors :( |
I think we should yank what we've published and publish 0.43.1 (with the correct version). I think we should also work on automating the release process in general; this step at least seems like it could plausibly happen entirely automatically. Testing that automation may be a bit painful, but maybe we can publish to a staging version of crates.io? I should be able to find the time to work on such automation in the next 6 weeks. In theory it should just be built-in to our normal release process I think. |
Bump stable version to 0.43.1 There was a hiccup where 0.43.0 was published to crates.io missing a change (#7848), see #7994 for details. It is not super critical, but in rare cases the bug can cause cargo used as a library to hang. I think bumping the version and re-publishing is relatively low-effort and low-risk. This also includes backports to appease CI: #7883 #7906 #7955.
I have bumped the version to 0.43.1 on the rust-1.42.0 branch. If someone with permission could re-publish cargo, this can be closed (make sure it is revision 5b129c4). |
Published! |
Thanks! |
Problem
It looks like 0.43.0 was published with the wrong version. rust 1.42.0 was published with 8633429 (seen at https://github.com/rust-lang/rust/tree/1.42.0/src/tools or running
cargo -V
). However, it looks like 0.43.0 was tagged with 9d32b7b (0.43.0), missing #7848, and the version on crates.io is also the older commit.I'm not sure what the best solution is. Maybe publish 0.43.1 with the fix?
Notes
@pietroalbini is there something we can do to improve the release process to avoid problems like these? This happened recently (#7503), and I'd like to try to avoid it happening again. I'm not familiar with your process, but if it is automated perhaps there's something that needs to be fixed?
The text was updated successfully, but these errors were encountered: