Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors from rustc are not shown on Windows. #8089

Closed
steffahn opened this issue Apr 8, 2020 · 5 comments
Closed

Colors from rustc are not shown on Windows. #8089

steffahn opened this issue Apr 8, 2020 · 5 comments
Labels
A-console-output Area: Terminal output, colors, progress bar, etc. C-bug Category: bug O-windows OS: Windows

Comments

@steffahn
Copy link
Member

steffahn commented Apr 8, 2020

Environment is Windows 7 with cmd.exe. Rust and cargo are stable 1.42, nightly does the same.

Here’s a screenshot:
Screenshot

struct S;
fn main() {
    let x = S;
    drop(x);
    drop(x);
}
@steffahn steffahn added the C-bug Category: bug label Apr 8, 2020
@steffahn

This comment has been minimized.

@rustbot

This comment has been minimized.

1 similar comment
@rustbot

This comment has been minimized.

@ehuss
Copy link
Contributor

ehuss commented Apr 8, 2020

This is actually an upstream issue. There's more detail at rust-lang/rust#55769. I have mostly forgotten where things stand, but I think there still might be a blocking issue (kennytm/fwdansi#2). There's also more detail about the reset problems in kennytm/fwdansi#1.

@ehuss ehuss added A-console-output Area: Terminal output, colors, progress bar, etc. O-windows OS: Windows labels Apr 8, 2020
@ehuss
Copy link
Contributor

ehuss commented Jul 31, 2020

This should be fixed on the latest nightly (2020-07-31) via #8540 and rust-lang/rust#74923.

@ehuss ehuss closed this as completed Jul 31, 2020
bors added a commit that referenced this issue Dec 18, 2022
Enable triagebot's relabel functionality

### What does this PR try to resolve?

This fixes the following failure that rustbot currently posts whenever someone tries to use "<b>`@</b><b>rustbot</b>` label" in this repository.

> **Error**: The feature `relabel` is not enabled in this repository.
> To enable it add its section in the `triagebot.toml` in the root of the repository.

Unauthenticated relabel has been enabled in rust-lang/rust for nearly 4 years. People overwhelmingly use it in good faith.

<br>

### How should we test and review this PR?

Compare against https://github.com/rust-lang/rust/blob/1.66.0/triagebot.toml.

Also skim through the 7 pages of labels on https://github.com/rust-lang/cargo/labels, whether it makes sense the ones I decided to allow arbitrary GitHub users to apply.

<br>

### Additional information

Attempted uses of "<b>`@</b><b>rustbot</b>` label", that failed, but this PR would allow:

- #10343 (comment)
- #10243 (comment)
- #9982 (comment)
- #9128 (comment)
- #9067 (comment)
- #8441 (comment)
- #11432 (comment)
- #8841 (comment)
- #10820 (comment)
- #10572 (comment)
- #9114 (comment)
- #8980 (comment)
- #9064 (comment)
- #8726 (comment)
- #8089 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-console-output Area: Terminal output, colors, progress bar, etc. C-bug Category: bug O-windows OS: Windows
Projects
None yet
Development

No branches or pull requests

3 participants