Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use # env-dep annotations in .d files produced by rustc to track dependencies on environment variables #8417

Closed
petrochenkov opened this issue Jun 26, 2020 · 0 comments · Fixed by #8421
Closed

Use # env-dep annotations in .d files produced by rustc to track dependencies on environment variables #8417

petrochenkov opened this issue Jun 26, 2020 · 0 comments · Fixed by #8421
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`

Comments

@petrochenkov
Copy link
Contributor

This will help to avoid majority of cargo:rerun-if-env-changed=VAR annotations in cargo build scripts and rerun builds automatically when environment variables change.

This is a cargo issue for rust-lang/rust#71858.
@petrochenkov petrochenkov added the C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` label Jun 26, 2020
@petrochenkov petrochenkov mentioned this issue Jun 26, 2020
Merged
@alexcrichton alexcrichton mentioned this issue Jun 26, 2020
Merged
bors added a commit that referenced this issue Jun 30, 2020
@bors
Auto merge of #8421 - alexcrichton:read-env-dep, r=ehuss
77b4058 
Parse `# env-dep` directives in dep-info files

This commit updates Cargo's parsing of rustc's dep-info files to account
for changes made upstream in rust-lang/rust#71858. This means that if
`env!` or `option_env!` is used in crate files Cargo will correctly
rebuild the crate if the env var changes.

Closes #8417
@bors bors closed this as completed in f666b19 Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parse # env-dep directives in dep-info files alexcrichton/cargo
1 participant
@petrochenkov