cargo-feature named-profiles ignored in Cargo.toml parsing

[wlmwlmwlm]

Problem
cargo-feature named-profiles is ignored and makes cargo barf on me, in:

cargo 1.51.0-nightly (329895f5b 2021-01-06)

... on a reasonably sane Linux installation.

Tracking issue for the named-profiles feature: #6988

Steps

Cargo.toml:

package]
name = "test"
version = "0.1.0"
authors = ["wlmwlmwlm <wlmwlmwlm@gmail.com>"]
edition = "2018"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

cargo-features = ["named-profiles"]

[profile.notworking]
inherits = "debug"
lto = true

[dependencies]

Source: (default main.rs)

Invocations:

$ cargo +nightly build
error: failed to parse manifest at `/home/wlmwlmwlm/named-profiles-reproduction/Cargo.toml`

Caused by:
  feature `named-profiles` is required

  consider adding `cargo-features = ["named-profiles"]` to the manifest

$ cargo +nightly build --profile notworking -Z unstable-options
error: failed to parse manifest at `/home/wlmwlmwlm/named-profiles-reproduction/Cargo.toml`

Caused by:
  feature `named-profiles` is required

  consider adding `cargo-features = ["named-profiles"]` to the manifest

[ehuss]

The line cargo-features needs to go at the top of Cargo.toml (above the [package] table), otherwise it is part of [package] table which is the wrong location.

We should probably add a special-case for this to give a better error message, and the docs should also be a little clearer about where it needs to go.

[wlmwlmwlm]

Awesome, that clears it up and solves my problem. I didn't realize any settings attach to the config tree root directly. -------- Oorspronkelijk bericht --------Van: Eric Huss <notifications@github.com> Datum: 14-01-21 02:49 (GMT+01:00) Aan: rust-lang/cargo <cargo@noreply.github.com> Cc: wlmwlmwlm <willem.mali+wlmgithub@gmail.com>, Author <author@noreply.github.com> Onderwerp: Re: [rust-lang/cargo] `cargo-feature` `named-profiles` ignored in   Cargo.toml parsing (#9074) The line cargo-features needs to go at the top of Cargo.toml (above the [package] table), otherwise it is part of [package] table which is the wrong location. We should probably add a special-case for this to give a better error message, and the docs should also be a little clearer about where it needs to go. —You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe. [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#9074 (comment)", "url": "#9074 (comment)", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

[wlmwlmwlm]

Awesome. If you reference ba3311e you'll see that the `Cargo.toml` docs where significantly expanded and a whole new error (with message) was added.

…

On Thu, Jan 21, 2021 at 10:43 PM bors ***@***.***> wrote: Closed #9074 <#9074> via ba3311e <ba3311e> . — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9074 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASNEMGZFIO6ARVMN6TE5DC3S3CNYBANCNFSM4WBV5C6Q> .