Move links above stats on crates.io #924
Comments
|
👍 |
|
Moving over to the crates.io repo, and thanks for the report! |
bors
added a commit
that referenced
this issue
Sep 30, 2017
Owner invite messages This PR addresses issue #4537, the plan for `cargo owner --add` requiring invitations in Cargo and the encompassing issue [#924](rust-lang/crates.io#924), requiring an invite to add someone as an owner in Crates.io. Regarding the Cargo issue, we went with Option 2, changing the `add_owners` function to decode a struct sent from Crates containing a `boolean` and `String`, the `boolean` being the response status and `String` being the success message. This may sound redundant however we concluded that using both of these fields were necessary to support older versions of Cargo - if we changed Crates.io to only return the `String` message on success this would likely break systems using the older version of `add_owner` expecting a response containing a `boolean`. Matching this schema, `add_owners` on the Crates.io side will soon return a struct containing a `boolean` and `String`, and instead of adding a new crate owner to the database will add a crate owner invite. If successful, `modify_owners` now prints the message sent from Crates.io instead of the old hardcoded message. Resolves #4537
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Stats are cool, but I wanted to go to the code repo and it took me forever to find it.
The text was updated successfully, but these errors were encountered: