book: add edit links to specific pages #10124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
reviewed
Nov 27, 2021
src/doc/book.toml
Outdated
| @@ -4,3 +4,4 @@ author = "Alex Crichton, Steve Klabnik and Carol Nichols, with Contributions fro | |||
|
|
|||
| [output.html] | |||
| git-repository-url = "https://github.com/rust-lang/cargo/tree/master/src/doc/src" | |||
| edit-url-template = "https://github.com/rust-lang/cargo/tree/master/src/doc/src/{path}" | |||
There was a problem hiding this comment.
I believe the path is relative to the book root.
Suggested change
| edit-url-template = "https://github.com/rust-lang/cargo/tree/master/src/doc/src/{path}" | |
| edit-url-template = "https://github.com/rust-lang/cargo/tree/master/src/doc/{path}" |
Also, is there a particular reason you chose to not go to the edit link? (Not that I have a strong preference, but that was the intended way to use this.)
matklad
force-pushed
the
edit-template-url
branch
from
f5908e9
to
3028bba
Compare
|
Thanks! I'm slightly concerned about receiving low-quality PRs with this, but hopefully it will result in more fixes instead. @bors r+ |
|
📌 Commit 3028bba has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 30, 2021
Update cargo 6 commits in 7f08ace4f1305de7f3b1b0e2f765911957226bd4..294967c53f0c70d598fc54ca189313c86c576ea7 2021-11-24 17:54:39 +0000 to 2021-11-29 19:04:22 +0000 - Fix some tests with output collisions. (rust-lang/cargo#10137) - Description of the targets that can be applied (rust-lang/cargo#10109) - Improve unused patch message when source URLs mismatched (rust-lang/cargo#10130) - Add a note about doctest xcompile. (rust-lang/cargo#10132) - book: add edit links to specific pages (rust-lang/cargo#10124) - Add crate type flag to rustc command (rust-lang/cargo#10093)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.