Remove strip = "off" (and undocumented strip = "n"/strip = "no")
#10376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `strip` option allows the string `"off"`, which `rustc` doesn't have, and maps it to `"none"`. Remove that equivalent, and just keep `"none"`. Simplify and clarify the documentation for `strip` accordingly. `strip` reused the `is_off` function from `lto`, which also had the net effect of allowing `"n"` and `"no"`, which weren't documented as supported. This change drops those as well.
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Requested by @tmandry to simplify Posting this PR to address it before the option becomes stable. |
Mark-Simulacrum
added
the
beta-nominated
|
@bors: r+ |
|
📌 Commit b3e5782 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Feb 10, 2022
[beta] Remove `strip = "off"` (and undocumented `strip = "n"`/`strip = "no"`) Beta backport of #10376 The `strip` option allows the string `"off"`, which `rustc` doesn't have, and maps it to `"none"`. Remove that equivalent, and just keep `"none"`. Simplify and clarify the documentation for `strip` accordingly. `strip` reused the `is_off` function from `lto`, which also had the net effect of allowing `"n"` and `"no"`, which weren't documented as supported. This change drops those as well.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 16, 2022
Update cargo 5 commits in c082648646cbb2be266df9ecbcdc253058158d68..ea2a21c994ca1e4d4c49412827b3cf4dcb158b1d 2022-02-08 14:55:05 +0000 to 2022-02-15 04:24:07 +0000 - cargo-new should not add ignore rule on Cargo.lock inside subdirs (rust-lang/cargo#10379) - Add a badge for github actions (rust-lang/cargo#10385) - Remove outdated badges (rust-lang/cargo#10380) - Remove `strip = "off"` (and undocumented `strip = "n"`/`strip = "no"`) (rust-lang/cargo#10376) - Fix unmatched backticks (rust-lang/cargo#10375)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.