feat: Support '-F' as an alias for '--features' #10576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This decision was part of rust-lang#10472 - It looks like all commands except `cargo-add` are using the prelude to define `--features`, so this should hit them all. - I've updated completions to the best of my knowledge. - It appears we don't need to update man pages or other documentation. - I'm assuming we don't add tests for every sort flag but rely on clap to have coverage to ensure it works.
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Hmm… I still love to see them mentioned in manpages for users to discover this new alias when running |
The manual change is to `src/doc/man/includes/section-features.md`, the rest is code-generated.
Done |
|
@bors r+ |
|
📌 Commit f728045 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 20, 2022
Update cargo 7 commits in dba5baf4345858c591517b24801902a062c399f8..edffc4ada3d77799e5a04eeafd9b2f843d29fc23 2022-04-13 21:58:27 +0000 to 2022-04-19 17:38:29 +0000 - Document cargo-add (rust-lang/cargo#10578) - feat: Support '-F' as an alias for '--features' (rust-lang/cargo#10576) - Completion support for `cargo-add` (rust-lang/cargo#10577) - Add a link to the document in the timings report (rust-lang/cargo#10492) - feat: Import cargo-add into cargo (rust-lang/cargo#10472) - Part 8 of RFC2906 - Keep `InheritableFields` in a `LazyCell` inside `… (rust-lang/cargo#10568) - Part 7 of RFC2906 - Add support for inheriting `exclude` and `include` (rust-lang/cargo#10565)
bors bot
added a commit
to taiki-e/cargo-llvm-cov
that referenced
this pull request
May 11, 2022
165: Support short flags of --release and --features r=taiki-e a=taiki-e - `--release` (`-r`) rust-lang/cargo#10133 - `--features` (`-F`) rust-lang/cargo#10576 Co-authored-by: Taiki Endo <te316e89@gmail.com>
bors bot
added a commit
to taiki-e/cargo-hack
that referenced
this pull request
May 12, 2022
150: Support short flag of --features r=taiki-e a=taiki-e refs: rust-lang/cargo#10576 Co-authored-by: Taiki Endo <te316e89@gmail.com>
sunshowers
pushed a commit
to nextest-rs/nextest
that referenced
this pull request
Jun 20, 2022
messense
added a commit
to messense/maturin
that referenced
this pull request
Jun 28, 2022
Cargo also does this in nightly channel: rust-lang/cargo#10576
bors
added a commit
that referenced
this pull request
Feb 26, 2023
Addition of support for -F as an alias for --features Updated documentation for #10576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Adds a short flag
-Ffor--features to all cargo commands to be consistent with the-F` short flag being added in #10472.How should we test and review this PR?
The decision for this is a part of #10472 which is in FCP.
cargo-addare using the prelude todefine
--features, so this should hit them all.to have coverage to ensure it works.
Review the commits separately. For the documentation change, the only manual change is in
src/doc/man/includes/section-features.md, the rest are code-generated.