Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove .masquerade_as_nightly_cargo() from build_script_extra_link_arg.rs #10866

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

Muscraft
Copy link
Member

When looking at making .masquerade_as_nightly_cargo() take in a list of reasons, I found that build_script_extra_link_arg.rs still was using it. extra-link-arg was stabilized in 1.56.0, so this PR removes .masquerade_as_nightly_cargo() from all the tests in this file.

@rust-highfive
Copy link

r? @ehuss

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 14, 2022
@ehuss
Copy link
Contributor

ehuss commented Jul 14, 2022

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 14, 2022

📌 Commit 2272159 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2022
@bors
Copy link
Collaborator

bors commented Jul 14, 2022

⌛ Testing commit 2272159 with merge 8529eb1...

@bors
Copy link
Collaborator

bors commented Jul 14, 2022

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 8529eb1 to master...

@bors bors merged commit 8529eb1 into rust-lang:master Jul 14, 2022
@Muscraft Muscraft deleted the update-extra-link-tests branch July 14, 2022 21:27
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 20, 2022
Update cargo

9 commits in 8827baaa781b37872134c1ba692a6f0aeb37890e..d8d30a75376f78bb0fabe3d28ee9d87aa8035309
2022-07-14 02:56:51 +0000 to 2022-07-19 13:59:17 +0000
- docs: fixing minor error in the default timing report filename (rust-lang/cargo#10879)
- Stabilize `--crate-type` flag for `cargo rustc` (rust-lang/cargo#10838)
- Stabilize `-Zmultitarget` (rust-lang/cargo#10766)
- Clean up leftover in unstable documentation (rust-lang/cargo#10874)
- Normalize path for `cargo vendor` output (rust-lang/cargo#10668)
- add a reason to `masquerade_as_nightly_cargo` so it is searchable (rust-lang/cargo#10868)
- Allow '.' in workspace.default-members in non-virtual workspaces. (rust-lang/cargo#10784)
- remove`.masquerade_as_nightly_cargo()` from various tests the no longer need it (rust-lang/cargo#10867)
- remove `.masquerade_as_nightly_cargo()` from build_script_extra_link_arg.rs (rust-lang/cargo#10866)
@ehuss ehuss added this to the 1.64.0 milestone Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants