Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(add): Clarify which version the features are added for #11075

Merged
merged 11 commits into from
Sep 13, 2022

Commits on Sep 12, 2022

  1. Configuration menu
    Copy the full SHA
    ddd44c8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    74e1a70 View commit details
    Browse the repository at this point in the history
  3. refactor(add): Consolidate looking up available features

    This optimization doesn't really make a difference and it makes it
    harder to separate UI / edit concerns.
    epage committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    2da6c04 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2715b56 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    391281b View commit details
    Browse the repository at this point in the history
  6. fix(add): Clarify which version the features are added for

    This gives a hint to users that we might not be showing the feature list
    for the latest version but the earliest version.
    
    Also when using a workspace dependency or re-using an existing
    dependency, this is a good reminder of what the version requirement is
    that was selected.
    
    However, when the user or add (the common case) selected a full
    precision requirement, this is redundant.
    
    I'm also mixed on whether the meta version should show up.
    
    Fixes rust-lang#11073
    epage committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    73906ae View commit details
    Browse the repository at this point in the history
  7. fix(add): Limit 'Features as of vX.Y.Z' to when relevant

    This will only show the messaeg if we didn't already show a version req
    with full precision specified ... mostly.  We'll also skip it if its a
    local or git dependency but we never show the version in those cases
    because it doesn't matter.
    
    The `precise_version` logic came from cargo-upgrade.
    epage committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    7ce2b7d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    be257b8 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Configuration menu
    Copy the full SHA
    f1548f6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1a20200 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5a6cfc9 View commit details
    Browse the repository at this point in the history