Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for overriding dl and api in config.json of registry index #11179

Closed
wants to merge 1 commit into from

Conversation

chenyuanrun
Copy link

See #6219 .

dl and api can be overrided in cargo config file like:

[source.crates-io]
replace-with = "dl-test"

[source.dl-test]
registry = "https://mirrors.tuna.tsinghua.edu.cn/git/crates.io-index.git"
dl = "https://crates-io.proxy.ustclug.org/api/v1/crates"

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2022
@bors
Copy link
Contributor

bors commented Oct 8, 2022

☔ The latest upstream changes (presumably #10907) made this pull request unmergeable. Please resolve the merge conflicts.

@weihanglo
Copy link
Member

Sorry for the extremely long wait 😅.

I am not quite sure the conclusion of #6219. Just what to clarify the intention of this change again:

  • Why the feature should be a built-in feature of Cargo.
  • What the current solution/workaround looks like without this feature, and how painful it is.
  • Does the config value http.proxy cover the need of this being built-in?

Also, I am not quite sure how it plays well with alternative registry authentication and the incoming asymmetric token authentication. How should overridden URLs interact with those authenticated endpoints? Should they just ignore, bypass or reuse the same auth token (which might be risky)? Would recommend we get back to #6219 for further discussions.

Hope I didn't get the purpose of this PR wrong. Thank you.

@weihanglo weihanglo added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2022
@weihanglo
Copy link
Member

Going to close this, as there are some unresolved design issues pending to be sorted out. Also, registry interaction internals has been changed a bit since then. I'd suggest having discussions in #6219 or on Zulip first. Thank you for putting effort on this :)

@weihanglo weihanglo closed this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants