Fix git2 safe-directory disable #11366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
In the process of fixing this, I noticed several other problems with git2, with fixes posted at libgit2/libgit2#6427 and rust-lang/git2-rs#894. I don't think either of those are necessary for cargo, though. Nominating for beta since this is a stable regression in 1.65. I'm not sure if it will be important for a stable backport. This is only the first report I've seen in the week since it is released, but it may be good to keep an eye on more reports. |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 12, 2022
Fix git2 safe-directory disable The call to `set_verify_owner_validation` was not getting called unless a network configuration was found. This means in the common case that `cargo new` will fail when there is a safe-directory error. This fixes the issue by making sure that `set_verify_owner_validation` is called before the early-exits in `init_git_transports`. Fixes #11365
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
ehuss
pushed a commit
to ehuss/cargo
that referenced
this pull request
Nov 15, 2022
Fix git2 safe-directory disable The call to `set_verify_owner_validation` was not getting called unless a network configuration was found. This means in the common case that `cargo new` will fail when there is a safe-directory error. This fixes the issue by making sure that `set_verify_owner_validation` is called before the early-exits in `init_git_transports`. Fixes rust-lang#11365
bors
added a commit
that referenced
this pull request
Nov 15, 2022
[beta-1.66] Backport fix for git2 safe-directory disable This is a beta backport of #11366.
weihanglo
added a commit
to weihanglo/rust
that referenced
this pull request
Nov 16, 2022
5 commits in a3dfea71ca0c888a88111086898aa833c291d497..16b097879b6f117c8ae698aab054c87f26ff325e 2022-11-11 03:50:47 +0000 to 2022-11-14 23:28:16 +0000 - improve error message for cargo add/remove (rust-lang/cargo#11375) - Bump crate versions of `cargo-util` and `crates-io` (rust-lang/cargo#11369) - doc(changelog): suggestions of cargo fix are nightly only (rust-lang/cargo#11373) - Add warning when PATH env separator is in project path (rust-lang/cargo#11318) - Fix git2 safe-directory disable (rust-lang/cargo#11366)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 16, 2022
Update cargo 5 commits in a3dfea71ca0c888a88111086898aa833c291d497..16b097879b6f117c8ae698aab054c87f26ff325e 2022-11-11 03:50:47 +0000 to 2022-11-14 23:28:16 +0000 - improve error message for cargo add/remove (rust-lang/cargo#11375) - Bump crate versions of `cargo-util` and `crates-io` (rust-lang/cargo#11369) - doc(changelog): suggestions of cargo fix are nightly only (rust-lang/cargo#11373) - Add warning when PATH env separator is in project path (rust-lang/cargo#11318) - Fix git2 safe-directory disable (rust-lang/cargo#11366) r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
set_verify_owner_validationwas not getting called unless a network configuration was found. This means in the common case thatcargo newwill fail when there is a safe-directory error. This fixes the issue by making sure thatset_verify_owner_validationis called before the early-exits ininit_git_transports.Fixes #11365