Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta-1.68] Backport fixes #11674

Merged
merged 2 commits into from
Feb 9, 2023
Merged

[beta-1.68] Backport fixes #11674

merged 2 commits into from
Feb 9, 2023

Commits on Feb 3, 2023

  1. Auto merge of rust-lang#11661 - arlosi:no-error-for-auth-required, r=… 

    …Eh2406

Do not error for `auth-required: true` without `-Z sparse-registry`

Registries that include `auth-required: true` in their `config.json` currently hit the following error on stable:
```
authenticated registries require `-Z registry-auth`
```

This situation makes it difficult for a registry to optionally offer the `auth-required: true` feature, since it forces users on to the nightly toolchain.

This PR changes the behavior to ignore the `auth-required: true` field of `config.json` without `-Z registry-auth`.

The downside to this change is that it makes it harder to discover why a registry isn't working, since the user will get an HTTP 401 error from the server, rather than a message from Cargo suggesting adding `-Z registry-auth`.

r? `@Eh2406`
    @bors @weihanglo
    bors authored and weihanglo committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    62ff2eb View commit details
    Browse the repository at this point in the history

  2. Auto merge of rust-lang#11672 - weihanglo:recompile-verify, r=epage 

    Verify source before recompile
    @bors @weihanglo
    bors authored and weihanglo committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    9faaba0 View commit details
    Browse the repository at this point in the history