Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend mdman tests. #11715

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Amend mdman tests. #11715

merged 1 commit into from
Feb 15, 2023

Conversation

Enyium
Copy link
Contributor

@Enyium Enyium commented Feb 15, 2023

  • Revert most of changes to expected test output from commit 2a4ec9f.
  • Keep later changes to expected test output from commit 0263ef4.
  • Change test input that's converted to trigger similar output as previously.

Following this comment from @ehuss.

@Enyium
Amend mdman tests.
36d3a5e 
- Revert most of changes to expected test output from commit 2a4ec9f.
- Keep later changes to expected test output from commit 0263ef4.
- Change test input that's converted to trigger similar output as previously.
@rustbot
Copy link
Collaborator

rustbot commented Feb 15, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-cli-help Area: built-in command-line help S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2023
weihanglo
weihanglo approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Thank you all.

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 15, 2023

📌 Commit 36d3a5e has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2023
@bors
Copy link
Contributor

bors commented Feb 15, 2023

⌛ Testing commit 36d3a5e with merge a59ac81...

@bors
Copy link
Contributor

bors commented Feb 15, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing a59ac81 to master...

@bors bors merged commit a59ac81 into rust-lang:master Feb 15, 2023
@ehuss
Copy link
Contributor

ehuss commented Feb 15, 2023

Thank you!

@weihanglo weihanglo mentioned this pull request Feb 17, 2023
Merged
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request Feb 18, 2023
@weihanglo
Update cargo
55a7915 
10 commits in 39c13e67a5962466cc7253d41bc1099bbcb224c3..17b3d0de0897e1c6b8ca347bd39f850bb0a5b9f6
2023-02-12 02:01:08 +0000 to 2023-02-17 19:45:09 +0000

- fix: unsupported protocol error on old macos version (rust-lang/cargo#11733)
- Error on invalid alphanumeric token for crates.io (rust-lang/cargo#11600)
- Add clippy lints (rust-lang/cargo#11722)
- chore: Make dependencies alphabetical order (rust-lang/cargo#11719)
- chore: bump mdbook to 0.4.27 (rust-lang/cargo#11716)
- Amend `mdman` tests. (rust-lang/cargo#11715)
- Run CI for macOS on nightly (rust-lang/cargo#11712)
- doc: doc comments and intra-doc links for `core::compiler` (rust-lang/cargo#11711)
- Ensure em dashes are recognizable in markup (rust-lang/cargo#11646)
- Set CARGO_BIN_NAME environment variable also for binary examples (rust-lang/cargo#11705)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 18, 2023
@matthiaskrgr
Rollup merge of rust-lang#108197 - weihanglo:update-cargo, r=weihanglo
5d5e0b0 
Update cargo

10 commits in 39c13e67a5962466cc7253d41bc1099bbcb224c3..17b3d0de0897e1c6b8ca347bd39f850bb0a5b9f6 2023-02-12 02:01:08 +0000 to 2023-02-17 19:45:09 +0000

- fix: unsupported protocol error on old macos version (rust-lang/cargo#11733)
- Error on invalid alphanumeric token for crates.io (rust-lang/cargo#11600)
- Add clippy lints (rust-lang/cargo#11722)
- chore: Make dependencies alphabetical order (rust-lang/cargo#11719)
- chore: bump mdbook to 0.4.27 (rust-lang/cargo#11716)
- Amend `mdman` tests. (rust-lang/cargo#11715)
- Run CI for macOS on nightly (rust-lang/cargo#11712)
- doc: doc comments and intra-doc links for `core::compiler` (rust-lang/cargo#11711)
- Ensure em dashes are recognizable in markup (rust-lang/cargo#11646)
- Set CARGO_BIN_NAME environment variable also for binary examples (rust-lang/cargo#11705)

r? `@ghost`
@ehuss ehuss added this to the 1.69.0 milestone Mar 9, 2023
@Enyium Enyium deleted the amend-mdman-tests branch October 8, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@epage epage

Labels
A-cli-help Area: built-in command-line help S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Enyium @rustbot @weihanglo @bors @ehuss @epage