Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more information to HTTP errors to help with debugging. #11878

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Add more information to HTTP errors to help with debugging. #11878

merged 4 commits into from
Apr 12, 2023

Commits on Apr 12, 2023

  1. Show some HTTP headers in error messages.

    @ehuss
    ehuss committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    c7c9b8f View commit details
    Browse the repository at this point in the history

  2. Include the IP address in HTTP errors.

    @ehuss
    ehuss committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    4702fa3 View commit details
    Browse the repository at this point in the history

  3. Don't display headers in spurious warning message. 

    The headers can significantly contribute to noise in the output,
drowning out the rest of the output. Most investigation will likely be
focused on the case where cargo completely fails to download, so this
only shows the full detail in the final error message.
    @ehuss
    ehuss committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    c00a633 View commit details
    Browse the repository at this point in the history

  4. Add x-amz-request-id (for the S3 side of things) and add comments.

    @ehuss
    ehuss committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    84bcf0e View commit details
    Browse the repository at this point in the history