-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error message when getting an empty dep table #11997
Conversation
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
3751c54
to
4d401bd
Compare
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
2659681
to
e0276ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. The new error message is much nicer to understand!
(BTW what the heck's the format change? Weird rustfmt behavior 🤔. NVM then)
@bors r+ |
☀️ Test successful - checks-actions |
Update cargo 14 commits in d0a4cbcee614fdb7ba66e860e603a00a644d71f8..de80432f04da61d98dcbbc1572598071718ccfd2 2023-04-16 17:42:50 +0000 to 2023-04-21 13:18:32 +0000 - Bump to 0.72.0; update changelog (rust-lang/cargo#12012) - Remove `src/doc` from `exclude` list in Cargo.toml (rust-lang/cargo#12000) - `--help` output use line wrap (rust-lang/cargo#12013) - Fix semver checks for 1.69 (rust-lang/cargo#12011) - Update contributor guide with new issue labels. (rust-lang/cargo#12003) - Better error message when getting an empty dep table (rust-lang/cargo#11997) - Fix broken links in contributor guide. (rust-lang/cargo#12002) - Update linux-raw-sys to 0.3.2 (rust-lang/cargo#11998) - chore: Use globs for workspace members (rust-lang/cargo#11996) - fix: Allow win/mac credential managers to build on all platforms (rust-lang/cargo#11993) - Add S-triage auto-label. (rust-lang/cargo#11995) - ci: check if Cargo.lock is up-to-date (rust-lang/cargo#11994) - Recompile on profile rustflags changes (rust-lang/cargo#11981) - Clarify some 1.69 changelog entries. (rust-lang/cargo#11982)
Update cargo 14 commits in d0a4cbcee614fdb7ba66e860e603a00a644d71f8..de80432f04da61d98dcbbc1572598071718ccfd2 2023-04-16 17:42:50 +0000 to 2023-04-21 13:18:32 +0000 - Bump to 0.72.0; update changelog (rust-lang/cargo#12012) - Remove `src/doc` from `exclude` list in Cargo.toml (rust-lang/cargo#12000) - `--help` output use line wrap (rust-lang/cargo#12013) - Fix semver checks for 1.69 (rust-lang/cargo#12011) - Update contributor guide with new issue labels. (rust-lang/cargo#12003) - Better error message when getting an empty dep table (rust-lang/cargo#11997) - Fix broken links in contributor guide. (rust-lang/cargo#12002) - Update linux-raw-sys to 0.3.2 (rust-lang/cargo#11998) - chore: Use globs for workspace members (rust-lang/cargo#11996) - fix: Allow win/mac credential managers to build on all platforms (rust-lang/cargo#11993) - Add S-triage auto-label. (rust-lang/cargo#11995) - ci: check if Cargo.lock is up-to-date (rust-lang/cargo#11994) - Recompile on profile rustflags changes (rust-lang/cargo#11981) - Clarify some 1.69 changelog entries. (rust-lang/cargo#11982)
What does this PR try to resolve?
close #11781
Give more details when getting an empty dep table.
How should we test and review this PR?
See the unit test.
Additional information
None