Improve error message for empty dep #12001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
|
r? @ehuss (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-manifest
Rustin170506
commented
Apr 20, 2023
| @@ -1589,7 +1591,9 @@ fn cannot_inherit_in_patch() { | |||
| .with_stderr( | |||
| "\ | |||
| [WARNING] [CWD]/Cargo.toml: unused manifest key: patch.crates-io.bar.workspace | |||
| [WARNING] [CWD]/Cargo.toml: dependency (bar) specified without providing a local path, Git repository, or version to use. This will be considered an error in future versions | |||
| [WARNING] [CWD]/Cargo.toml: dependency (bar) specified without providing a local path, Git repository, version, \ | |||
There was a problem hiding this comment.
This warning message is quite confusing.
It is not an empty dep:
[workspace.dependencies]
bar = { path = "bar" }But the warning said it is.
There was a problem hiding this comment.
Is there any existing issue, or could you submit one?
There was a problem hiding this comment.
I will submit it later.
weihanglo
approved these changes
Apr 24, 2023
| @@ -1589,7 +1591,9 @@ fn cannot_inherit_in_patch() { | |||
| .with_stderr( | |||
| "\ | |||
| [WARNING] [CWD]/Cargo.toml: unused manifest key: patch.crates-io.bar.workspace | |||
| [WARNING] [CWD]/Cargo.toml: dependency (bar) specified without providing a local path, Git repository, or version to use. This will be considered an error in future versions | |||
| [WARNING] [CWD]/Cargo.toml: dependency (bar) specified without providing a local path, Git repository, version, \ | |||
There was a problem hiding this comment.
Is there any existing issue, or could you submit one?
|
@bors r+ |
bors
added
S-waiting-on-bors
|
Thanks for your review! 💚 💙 💜 💛 ❤️ |
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2023
Update cargo 17 commits in de80432f04da61d98dcbbc1572598071718ccfd2..9e586fbd8b931494067144623b76c37d213b1ab6 2023-04-21 13:18:32 +0000 to 2023-04-25 22:09:11 +0000 - Update home dependency (rust-lang/cargo#12037) - Warn instead of error in `cargo package` on empty `readme` or `license-file` in manifest (rust-lang/cargo#12036) - Clarify documentation around test target setting. (rust-lang/cargo#12032) - fix: apply `[env]` to target info discovery rustc (rust-lang/cargo#12029) - CI: ensure intra links for all members are checked (rust-lang/cargo#12025) - chore: make credential dependencies platform-specific (rust-lang/cargo#12027) - CI: use `-p` to specify workspace members instead of `--manifest-path` (rust-lang/cargo#12024) - ci: requires `test_gitoxide` and `lockfile` for both bors success and failure (rust-lang/cargo#12026) - Update windows-sys (rust-lang/cargo#12021) - Bump libc to 0.2.142 (rust-lang/cargo#12014) - Update openssl-src to 111.25.3+1.1.1t (rust-lang/cargo#12005) - Improve error message for empty dep (rust-lang/cargo#12001) - Remove wrong url in benchsuite manifest. (rust-lang/cargo#12020) - Bump versions of local crates (rust-lang/cargo#12019) - Add the Win32_System_Console feature since it is used (rust-lang/cargo#12016) - Update outdated crates.io URLs in publishing guide (rust-lang/cargo#12018) - Allow named debuginfo options in Cargo.toml (rust-lang/cargo#11958) r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Improve error message for empty dep. Now we can specify a workspace dep in the table.
How should we test and review this PR?
See the unit tests.
Additional information
Should we make it an error? Because this warning exists for a long time.