Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix clippy warnings #12050

Closed
wants to merge 1 commit into from
Closed

fix clippy warnings #12050

wants to merge 1 commit into from

Conversation

Byron
Copy link
Member

@Byron Byron commented Apr 27, 2023

I thought it would be useful to fix all warnings so those who run clippy will only see warnings of their own making.

That said, I am quite unsure outside of tests whether I have given a sensible explanation for why one wouldn't need to use Config::get_env_var_os() in all the cases I allowed it.

@rustbot
Copy link
Collaborator

rustbot commented Apr 27, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-cfg-expr Area: Platform cfg expressions A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2023
@epage
Copy link
Contributor

epage commented Apr 27, 2023

Thanks for your PR!

Cargo team is not accepting clippy PR at this moment (See #9356). I am going to close it out. I do appreciate you taking a look at this!

From #11195, see also #11867

@epage epage closed this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@epage epage

Labels
A-cfg-expr Area: Platform cfg expressions A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Byron @rustbot @epage