Replace invalid panic_unwind
std feature with panic-unwind
#12364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
The documentation for the unstable
build-std-features
flag mentions that a default-enabled feature forstd
ispanic_unwind
. However, as of 2023-07-16, that feature does not even exist in the latest nightlies:The
std
Cargo.toml
does not contain thepanic_unwind
feature either, but it defines apanic-unwind
feature, which works as intended with thebuild-std-features
flag.Therefore, let's update the documentation to refer to the intended feature instead, which improves its accuracy and reduces developer time waste.
How should we test and review this PR?
Run e.g.
cargo build --release -Z build-std -Z build-std-features=panic-unwind --target x86_64-unknown-linux-gnu
instead ofcargo build --release -Z build-std -Z build-std-features=panic_unwind --target x86_64-unknown-linux-gnu
, and watch how the first one works as intended but the second one just shows an error.