Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta-1.73.0] add missing windows-sys features back #12564

Merged
merged 2 commits into from
Aug 26, 2023
Merged

[beta-1.73.0] add missing windows-sys features back #12564

merged 2 commits into from
Aug 26, 2023

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Aug 26, 2023 •
edited
Loading

Fixes #12562

Beta backports:

In order to make CI pass, the following PRs are also cherry-picked:

@rustbot
Copy link
Collaborator

rustbot commented Aug 26, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2023
@weihanglo weihanglo changed the base branch from master to rust-1.73.0 August 26, 2023 10:13
@weihanglo weihanglo mentioned this pull request Aug 26, 2023
Merged
@epage
Copy link
Contributor

epage commented Aug 26, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Aug 26, 2023

📌 Commit 716f919 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2023
@bors
Copy link
Contributor

bors commented Aug 26, 2023

⌛ Testing commit 716f919 with merge d92a694...

bors added a commit that referenced this pull request Aug 26, 2023
@bors
Auto merge of #12564 - weihanglo:rust-1.73.0-backport, r=epage
d92a694 
[beta-1.73.0] add missing `windows-sys` features back

Fixes <#12562>

Beta backports:

- <#12563>

In order to make CI pass, the following PRs are also cherry-picked:

-
@bors
Copy link
Contributor

bors commented Aug 26, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 26, 2023
@epage @weihanglo
docs: Remove redundant explicit link
c46e2c5 
CI is currently broken due to a new warning in nightlies
@ehuss
Copy link
Contributor

ehuss commented Aug 26, 2023

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Aug 26, 2023

📌 Commit c46e2c5 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2023
@bors
Copy link
Contributor

bors commented Aug 26, 2023

⌛ Testing commit c46e2c5 with merge 9c4383f...

@bors
Copy link
Contributor

bors commented Aug 26, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 9c4383f to rust-1.73.0...

@bors bors merged commit 9c4383f into rust-lang:rust-1.73.0 Aug 26, 2023
20 checks passed
@weihanglo weihanglo deleted the rust-1.73.0-backport branch August 26, 2023 17:48
@weihanglo weihanglo mentioned this pull request Aug 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 27, 2023
@bors
Auto merge of rust-lang#115282 - weihanglo:update-beta-cargo, r=weiha…
bc28abf 
…nglo

[beta-1.73] Update cargo

1 commits in 80eca0e58fb2ff52c1e94fc191b55b37ed73e0e4..9c4383fb55986096b414d98125421ab87b5fd642
2023-08-19 00:52:06 +0000 to 2023-08-26 16:07:09 +0000
- [beta-1.73.0] add missing `windows-sys` features back (rust-lang/cargo#12564)

r? ghost
@ehuss ehuss added this to the 1.73.0 milestone Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

cargo 0.73 build broken on windows
5 participants
@weihanglo @rustbot @epage @bors @ehuss