Skip to content

Conversation

0xPoe
Copy link
Member

@0xPoe 0xPoe commented Oct 7, 2023

What does this PR try to resolve?

ref #11702

Added unsupported lowercase -z flag suggestion for -Z flag.

How should we test and review this PR?

Check out the unit test.

Additional information

None

@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2023
Copy link
Member Author

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check

@0xPoe 0xPoe force-pushed the rustin-patch-short-Z branch from 083b495 to 272c69e Compare October 7, 2023 14:13
0xPoe added 2 commits October 8, 2023 08:36
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@0xPoe 0xPoe force-pushed the rustin-patch-short-Z branch from 272c69e to f9719dc Compare October 8, 2023 00:39
@0xPoe 0xPoe force-pushed the rustin-patch-short-Z branch from b6edd33 to c3f67ad Compare October 10, 2023 00:48
@0xPoe 0xPoe requested a review from epage October 10, 2023 00:49
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@0xPoe 0xPoe force-pushed the rustin-patch-short-Z branch from c3f67ad to d1540cc Compare October 10, 2023 00:59
Copy link
Member Author

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked

@epage
Copy link
Contributor

epage commented Oct 10, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Oct 10, 2023

📌 Commit d1540cc has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2023
@bors
Copy link
Contributor

bors commented Oct 10, 2023

⌛ Testing commit d1540cc with merge c97c906...

@bors
Copy link
Contributor

bors commented Oct 10, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing c97c906 to master...

@bors bors merged commit c97c906 into rust-lang:master Oct 10, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 11, 2023
Update cargo

5 commits in 794d0a82547f3081044c0aca7b6083733ce51344..6fa6fdc7606cfa664f9bee2fb33ee2ed904f4e88
2023-10-03 23:19:33 +0000 to 2023-10-10 23:06:08 +0000
- test(build): generalize test assertion for non-rustup env (rust-lang/cargo#12804)
- chore: Sort dependency tables (rust-lang/cargo#12803)
- fix(install): Suggest an alternative version on MSRV failure (rust-lang/cargo#12798)
- rustdoc: remove the word "Version" from test cases (rust-lang/cargo#12800)
- Add unsupported lowercase `-z` flag suggestion for `-Z` flag (rust-lang/cargo#12788)

r? ghost
@ehuss ehuss added this to the 1.75.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants