Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable 1.73] backport publish script fixes #12792

Merged
merged 2 commits into from
Oct 7, 2023
Merged

[stable 1.73] backport publish script fixes #12792

merged 2 commits into from
Oct 7, 2023

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 7, 2023

Backports:

  • Add credential crates from 12649. I didn't realize that these crates were added as unstable dependencies in 1.73, and thus were required for publishing. @Mark-Simulacrum has already published the missing versions, but I am updating this just to be thorough.
  • Remove sleep from publish.py: Remove obsolete sleep() calls #12686. This is just so the publish doesn't take forever.

ehuss and others added 2 commits October 7, 2023 14:15
@ehuss
[stable 1.73] backport credential publish
8ef08e8
@bors @ehuss
Auto merge of rust-lang#12686 - Turbo87:publish-script, r=epage
b5bec7e 
publish.py: Remove obsolete `sleep()` calls

`cargo` waits for the package to appear in the index by default these days, so these obsolete extra `sleep()` calls are just making the publish process slower now without any advantages.

see https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/publish.2Epy
@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.73.0. Please double check that you specified the right target!

@rustbot rustbot added A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2023
@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 7, 2023

📌 Commit b5bec7e has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2023
@bors
Copy link
Contributor

bors commented Oct 7, 2023

⌛ Testing commit b5bec7e with merge d252bce...

@bors
Copy link
Contributor

bors commented Oct 7, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing d252bce to rust-1.73.0...

@bors bors merged commit d252bce into rust-lang:rust-1.73.0 Oct 7, 2023
18 checks passed
@ehuss ehuss added this to the 1.73.0 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@epage epage

Labels
A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ehuss @rustbot @weihanglo @bors @epage