Redesign features #1294
Redesign features #1294
Conversation
See the associated issue for more details. Closes rust-lang#1286.
| return HashMap::new(); | ||
| } | ||
|
|
||
| raw.as_ref().unwrap().iter().map(|(name, desc)| { |
There was a problem hiding this comment.
Could this unwrap be transformed into:
let raw = match *raw {
Some(ref raw) => raw,
None => return HashMap::new()
};
|
This looks all good to me, thanks @sfackler! I think that we're going to want to be more aggressive about a transition plan, however, instead of just breaking the old behavior. Would it be possible for |
|
I can also work more on the crates.io-half of the features here if you'd like, although it may have to wait until after alpha2 depending on what else needs to land. |
|
Closing due to inactivity, but I'd still be interested in a change along these lines happening! |
|
RIP |
Note
A crates.io update needs to be made before this can merge. I'm opening this now to get feedback.
Closes #1286.
r? @alexcrichton