Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fill in more empty name holes #13164

Merged
merged 5 commits into from
Dec 13, 2023
Merged

fix: Fill in more empty name holes #13164

merged 5 commits into from
Dec 13, 2023

Commits on Dec 13, 2023

  1. test: Demonstrate existing empty name errors

    @epage
    epage committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    7200646 View commit details
    Browse the repository at this point in the history

  2. fix!: Disallow empty registry names 

    This was allowed when switching from `toml` v0.5 to `toml_edit` which
started allowing empty keys when parsing TOML.
This mirrors the change
we made for disallowing empty feature names in rust-lang#12928.
    @epage
    epage committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    1791353 View commit details
    Browse the repository at this point in the history

  3. fix(add): Catch empty dep name early

    @epage
    epage committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    9de03cd View commit details
    Browse the repository at this point in the history

  4. fix(new): Catch empty package names earlier

    @epage
    epage committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    2db5c9d View commit details
    Browse the repository at this point in the history

  5. refactor: Centralize empty name check

    @epage
    epage committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    a383185 View commit details
    Browse the repository at this point in the history