Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove version field from publish=false packages #13254

Closed
wants to merge 4 commits into from
Closed

chore: remove version field from publish=false packages #13254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24c00a3
chore: remove `version` field from `publish=false` packages
weihanglo Jan 24, 2024
55b72ab
chore(ci): cargo-hack `--no-private`
weihanglo Jan 24, 2024
b0a8a2c
chore(ci): cargo-hack `--no-dev-deps`
weihanglo Jan 25, 2024
ebb7ff4
docs(ci): also suggest `cargo hack --no-private`
weihanglo Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,4 +258,4 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: taiki-e/install-action@cargo-hack
- run: cargo hack check --all-targets --rust-version --workspace --ignore-private
- run: cargo hack check --rust-version --workspace --no-private --no-dev-deps
6 changes: 3 additions & 3 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions benches/benchsuite/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
[package]
name = "benchsuite"
version = "0.0.0"
edition.workspace = true
license.workspace = true
homepage = "https://github.com/rust-lang/cargo"
repository = "https://github.com/rust-lang/cargo"
description = "Benchmarking suite for Cargo."
publish = false

[dependencies]
cargo.workspace = true
Expand Down
2 changes: 0 additions & 2 deletions benches/capture/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
[package]
name = "capture"
version = "0.1.0"
edition.workspace = true
license.workspace = true
description = "Tool for capturing a real-world workspace for benchmarking."
publish = false

[dependencies]
cargo_metadata.workspace = true
Expand Down
2 changes: 0 additions & 2 deletions crates/cargo-test-macro/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
[package]
name = "cargo-test-macro"
version = "0.1.0"
edition.workspace = true
license.workspace = true
homepage.workspace = true
repository.workspace = true
documentation = "https://github.com/rust-lang/cargo"
description = "Helper proc-macro for Cargo's testsuite."
publish = false

[lib]
proc-macro = true
Expand Down
2 changes: 0 additions & 2 deletions crates/cargo-test-support/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
[package]
name = "cargo-test-support"
version = "0.1.0"
license.workspace = true
edition.workspace = true
publish = false

[lib]
doctest = false
Expand Down
2 changes: 0 additions & 2 deletions crates/mdman/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
[package]
name = "mdman"
version = "0.0.0"
edition.workspace = true
license.workspace = true
description = "Creates a man page page from markdown."
publish = false

[dependencies]
anyhow.workspace = true
Expand Down
2 changes: 0 additions & 2 deletions crates/resolver-tests/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
[package]
name = "resolver-tests"
version = "0.0.0"
edition.workspace = true
publish = false

[dependencies]
cargo.workspace = true
Expand Down
2 changes: 0 additions & 2 deletions crates/semver-check/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
[package]
name = "semver-check"
version = "0.0.0"
authors = ["Eric Huss"]
edition.workspace = true
publish = false

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

Expand Down
2 changes: 0 additions & 2 deletions crates/xtask-build-man/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
[package]
name = "xtask-build-man"
version = "0.0.0"
edition.workspace = true
publish = false

[dependencies]

Expand Down
2 changes: 0 additions & 2 deletions crates/xtask-bump-check/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
[package]
name = "xtask-bump-check"
version = "0.0.0"
edition.workspace = true
publish = false

[dependencies]
anyhow.workspace = true
Expand Down
2 changes: 0 additions & 2 deletions crates/xtask-stale-label/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
[package]
name = "xtask-stale-label"
version = "0.0.0"
edition.workspace = true
publish = false

[dependencies]
toml_edit.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion src/doc/src/guide/continuous-integration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: taiki-e/install-action@cargo-hack
- run: cargo hack check --rust-version --workspace --all-targets --ignore-private
- run: cargo hack check --rust-version --workspace --all-targets --no-private
```
This tries to balance thoroughness with turnaround time:
- A single platform is used as most projects are platform-agnostic, trusting platform-specific dependencies to verify their behavior.
Expand Down