Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document why du function uses mutex #13273

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Document why du function uses mutex #13273

merged 4 commits into from
Jan 10, 2024

Conversation

BD103
Copy link
Contributor

@BD103 BD103 commented Jan 9, 2024

What does this PR try to resolve?

After closing #13253, it was suggested to document why the du function uses a Mutex instead of an AtomicU64. This will prevent others from making the same mistake I did. :)

How should we test and review this PR?

N/A

Additional information

N/A

@rustbot
Copy link
Collaborator

rustbot commented Jan 9, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 9, 2024
@BD103 BD103 mentioned this pull request Jan 9, 2024
Closed
@BD103 @weihanglo
fix: missing word in comment
529130f 
Co-authored-by: Weihang Lo <weihanglo@users.noreply.github.com>
@weihanglo
Copy link
Member

The version bump check failed. Could you bump cargo-util to 0.2.10 here? Thank you.

cargo/crates/cargo-util/Cargo.toml

Line 3 in 529130f

version = "0.2.9"

@BD103
Copy link
Contributor Author

BD103 commented Jan 10, 2024

I had some confusion with the CI, but it should pass now. :)

@weihanglo
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jan 10, 2024

📌 Commit 0a6fe23 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2024
@bors
Copy link
Contributor

bors commented Jan 10, 2024

⌛ Testing commit 0a6fe23 with merge 187d4cf...

@bors
Copy link
Contributor

bors commented Jan 10, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 187d4cf to master...

@bors bors merged commit 187d4cf into rust-lang:master Jan 10, 2024
17 of 22 checks passed
@weihanglo weihanglo mentioned this pull request Jan 12, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 13, 2024
@bors
Auto merge of rust-lang#119909 - weihanglo:update-cargo, r=weihanglo
1825374 
Update cargo

8 commits in 3e428a38a34e820a461d2cc082e726d3bda71bcb..84976cd699f4aea56cb3a90ce3eedeed9e20d5a5
2024-01-09 20:46:36 +0000 to 2024-01-12 15:55:43 +0000
- fix(resolver): do not panic when sorting empty summaries (rust-lang/cargo#13287)
- Implementation of shallow libgit2 fetches behind an unstable flag (rust-lang/cargo#13252)
- Add documentation entry for unstable `--output-format` flag (rust-lang/cargo#13284)
- doc: add `public` info in `cargo-add` man page. (rust-lang/cargo#13272)
- More docs on prerelease compat (rust-lang/cargo#13286)
- Add unstable `--output-format` option to  `cargo rustdoc` (rust-lang/cargo#12252)
- feat: Add `rustc` style errors for manifest parsing (rust-lang/cargo#13172)
- Document why `du` function uses mutex (rust-lang/cargo#13273)

r? ghost
@ehuss ehuss added this to the 1.77.0 milestone Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
5 participants
@BD103 @rustbot @weihanglo @bors @ehuss