Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: [package] doesn't require version field #13390

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

stevenengler
Copy link
Contributor

Since #12786 (in 1.75) cargo doesn't require the version field as it defaults to 0.0.0. A bin crate with the following toml builds successfully with cargo build:

[package]
name = "foo"

This PR slightly rewords the [package] section of src/doc/src/reference/manifest.md to reflect this.

@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2024
@weihanglo
Copy link
Member

Nice catch. Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 4, 2024

📌 Commit 1a2e4f2 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2024
@bors
Copy link
Contributor

bors commented Feb 4, 2024

⌛ Testing commit 1a2e4f2 with merge 8c96a1a...

@epage
Copy link
Contributor

epage commented Feb 4, 2024

@weihanglo looks like PRs are blocked on doing the version bump in master

@weihanglo
Copy link
Member

@weihanglo looks like PRs are blocked on doing the version bump in master

I'll do that later or tomorrow!

@bors
Copy link
Contributor

bors commented Feb 4, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 8c96a1a to master...

@bors bors merged commit 8c96a1a into rust-lang:master Feb 4, 2024
20 of 21 checks passed
@stevenengler stevenengler deleted the doc-version branch February 4, 2024 02:28
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2024
Update cargo

14 commits in cdf84b69d0416c57ac9dc3459af80dfb4883d27a..ccc84ccec4b7340eb916aefda1cb3e2fe17d8e7b
2024-02-02 19:39:16 +0000 to 2024-02-07 15:37:49 +0000
- Relax a test to permit warnings to be emitted, too. (rust-lang/cargo#13415)
- test: disable lldb test as it requires privileges to run on macOS (rust-lang/cargo#13416)
- Update git2 (rust-lang/cargo#13412)
- fix: Switch more notes/warnings to lowercase (rust-lang/cargo#13410)
- Don't add the new package to workspace.members if there is no existing workspace in Cargo.toml. (rust-lang/cargo#13391)
- Remove build metadata from curl-sys version. (rust-lang/cargo#13401)
- Fix markdown line break in cargo-add (rust-lang/cargo#13400)
- Remove `package.documentation` from the “before publishing” list. (rust-lang/cargo#13398)
- chore(deps): update gix (rust-lang/cargo#13380)
- chore(deps): update compatible (rust-lang/cargo#13379)
- feat(update): Tell users when they are still behind (rust-lang/cargo#13372)
- docs(changelog): Slight cleanup (rust-lang/cargo#13396)
- Bump to 0.79.0; update changelog (rust-lang/cargo#13392)
- doc: `[package]` doesn't require `version` field (rust-lang/cargo#13390)

r? ghost
@ehuss ehuss added this to the 1.78.0 milestone Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants