Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add tests for using worktrees and sparse checkouts #13567

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

LuuuXXX
Copy link
Contributor

@LuuuXXX LuuuXXX commented Mar 9, 2024

What does this PR try to resolve?

Based on @eminence's comment, Add tests for using worktrees or spase checkouts.

How should we test and review this PR?

Checkout and run tests:

cargo test --package cargo --test testsuite -- git::git_worktree_with_original_repo_renamed
cargo test --package cargo --test testsuite -- git::git_worktree_with_bare_original_repo

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 9, 2024
@LuuuXXX LuuuXXX force-pushed the issue-7876 branch 3 times, most recently from 8954c6d to 9152184 Compare March 10, 2024 05:07
tests/testsuite/git.rs Outdated Show resolved Hide resolved
tests/testsuite/git.rs Outdated Show resolved Hide resolved
tests/testsuite/git.rs Outdated Show resolved Hide resolved
tests/testsuite/git.rs Outdated Show resolved Hide resolved
tests/testsuite/git.rs Show resolved Hide resolved
@LuuuXXX LuuuXXX force-pushed the issue-7876 branch 2 times, most recently from adf2d53 to c248dad Compare March 11, 2024 10:01
tests/testsuite/git.rs Outdated Show resolved Hide resolved
tests/testsuite/git.rs Outdated Show resolved Hide resolved
tests/testsuite/git.rs Outdated Show resolved Hide resolved
@weihanglo
Copy link
Member

Looks great. Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Mar 11, 2024

📌 Commit 062d8ce has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2024
@bors
Copy link
Contributor

bors commented Mar 11, 2024

⌛ Testing commit 062d8ce with merge fe5de07...

@bors
Copy link
Contributor

bors commented Mar 11, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing fe5de07 to master...

@bors bors merged commit fe5de07 into rust-lang:master Mar 11, 2024
21 checks passed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2024
Update cargo

9 commits in a4c63fe5388beaa09e5f91196c86addab0a03580..7065f0ef4aa267a7455e1c478b5ccacb7baea59c
2024-03-06 22:15:17 +0000 to 2024-03-12 13:25:15 +0000
- chore: remove repetitive word (rust-lang/cargo#13575)
- refactor(lockfile): Make diffing/printing more reusable (rust-lang/cargo#13564)
- test: Add tests for using worktrees and sparse checkouts (rust-lang/cargo#13567)
- util/network/http: Use `cargo/1.2.3` user-agent header (rust-lang/cargo#13548)
- fix: Consistently compare MSRVs (rust-lang/cargo#13537)
- refactor(shell): Use alternate to close links (rust-lang/cargo#13562)
- fix(doc): Collapse down Generated statuses without --verbose (rust-lang/cargo#13557)
- doc: Add doc for -Zpublic-dependency (rust-lang/cargo#13556)
- docs: add link to the exported_private_dependencies lint (rust-lang/cargo#13547)

r? ghost
@rustbot rustbot added this to the 1.78.0 milestone Mar 12, 2024
@codewriter3000
Copy link

I still have this issue running 1.83.0-nightly.

@weihanglo
Copy link
Member

@codewriter3000 could you share more details and a minimal reproduction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo dies when in worktree of bare repository cargo publish doesn't work well with git worktrees
6 participants