Remove unnecessary test

[jhpratt]

This removes a test that is blocking rust-lang/rust#116016 from landing. @dtolnay suggested removing the test rather than allowing the relevant lints (comment).

The failure is in

cargo/tests/testsuite/check.rs

Lines 222 to 285 in 77506e5

	// Some weirdness that seems to be caused by a crate being built as well as
	// checked, but in this case with a proc macro too.
	#[cargo_test]
	fn issue_3419() {
	let p = project()
	.file(
	"Cargo.toml",
	r#"
	[package]
	name = "foo"
	version = "0.0.1"
	edition = "2015"
	authors = []
	[dependencies]
	rustc-serialize = "*"
	"#,
	)
	.file(
	"src/lib.rs",
	r#"
	extern crate rustc_serialize;
	use rustc_serialize::Decodable;
	pub fn take<T: Decodable>() {}
	"#,
	)
	.file(
	"src/main.rs",
	r#"
	extern crate rustc_serialize;
	extern crate foo;
	#[derive(RustcDecodable)]
	pub struct Foo;
	fn main() {
	foo::take::<Foo>();
	}
	"#,
	)
	.build();
	Package::new("rustc-serialize", "1.0.0")
	.file(
	"src/lib.rs",
	r#"
	pub trait Decodable: Sized {
	fn decode<D: Decoder>(d: &mut D) -> Result<Self, D::Error>;
	}
	pub trait Decoder {
	type Error;
	fn read_struct<T, F>(&mut self, s_name: &str, len: usize, f: F)
	-> Result<T, Self::Error>
	where F: FnOnce(&mut Self) -> Result<T, Self::Error>;
	}
	"#,
	)
	.publish();
	p.cargo("check").run();
	}

which is a 7 year old test for rust-lang/cargo#3419, which is from 2 days after the initial implementation of cargo check landed in nightly Cargo in rust-lang/cargo#3296.

I would recommend just deleting the test from Cargo. The implementation of cargo check has matured enough since then and I don't see anything useful in that test.

[rustbot]

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[weihanglo]

Agree that we might not need the test. The original fix was like handling cargo check to correctly emit rmeta, which should be covered by other cargo check test nowadays.

[weihanglo]

@bors r+

[bors]

📌 Commit def06ee has been approved by weihanglo

It is now in the queue for this repository.

[bors]

⌛ Testing commit def06ee with merge a510712...

[bors]

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing a510712 to master...