Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(semver): remove mention of deprecated tool rust-semverver #13715

Merged
merged 1 commit into from
Apr 6, 2024
Merged

doc(semver): remove mention of deprecated tool rust-semverver #13715

merged 1 commit into from
Apr 6, 2024

Conversation

weihanglo
Copy link
Member

@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2024
@epage
Copy link
Contributor

epage commented Apr 6, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Apr 6, 2024

📌 Commit 3c652b7 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2024
@bors
Copy link
Contributor

bors commented Apr 6, 2024

⌛ Testing commit 3c652b7 with merge ec2b323...

@bors
Copy link
Contributor

bors commented Apr 6, 2024

☀️ Test successful - checks-actions
Approved by: epage
Pushing ec2b323 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Apr 6, 2024

☀️ Test successful - checks-actions
Approved by: epage
Pushing ec2b323 to master...

@bors bors merged commit ec2b323 into rust-lang:master Apr 6, 2024
21 checks passed
@bors
Copy link
Contributor

bors commented Apr 6, 2024

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@weihanglo weihanglo deleted the remove-semverver branch April 6, 2024 15:11
@Kobzol
Copy link
Contributor

Kobzol commented Apr 7, 2024 •
edited
Loading

Maybe we could mention cargo-semver-checks instead? It seems to be a spiritual successor of rust-semverver.

@epage
Copy link
Contributor

epage commented Apr 7, 2024 •
edited
Loading

While I am excited about cargo-semver-checks and look forward to it being mature enough for wide use, I think promoting it at this stage is harmful to good community norms.

The design of it and the action encourage updating your version number during development. This prevents use of [patch] because it needs the version number in the registry and git to match (e.g. dependents verifying changes in git before release).

Yes, in the cargo repo, versions are bumped during development and cargo-semver-checks is used. However, I want to see those practices change; we just aren't there yet with our release process which is unlike most open source projects.

@weihanglo weihanglo mentioned this pull request Apr 10, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 10, 2024
@bors
Auto merge of rust-lang#123745 - weihanglo:update-cargo, r=weihanglo
aa067fb 
Update cargo

11 commits in 28e7b2bc0a812f90126be30f48a00a4ada990eaa..74fd5bc730b828dbc956335b229ac34ba47f7ef7
2024-04-05 19:31:01 +0000 to 2024-04-10 18:40:49 +0000
- chore: downgrade to openssl v1.1.1 (again) (rust-lang/cargo#13731)
- fix(cargo-fix): dont apply same suggestion twice (rust-lang/cargo#13728)
- refactor: make `resolve_with_previous` clearer (rust-lang/cargo#13727)
- fix(package): Normalize paths in `Cargo.toml` (rust-lang/cargo#13729)
- refactor: Track when MSRV is explicitly set, either way (rust-lang/cargo#13732)
- [fix]:Build script not rerun when target rustflags change (rust-lang/cargo#13560)
- feat(add): Stabilize MSRV-aware version req selection (rust-lang/cargo#13608)
- Fix github fast path redirect. (rust-lang/cargo#13718)
- Add release notes for 1.77.1 (rust-lang/cargo#13717)
- doc(semver): remove mention of deprecated tool rust-semverver (rust-lang/cargo#13715)
- chore: fix some typos (rust-lang/cargo#13714)

r? ghost
@ehuss ehuss added this to the 1.79.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@epage epage

Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
6 participants
@weihanglo @rustbot @epage @bors @Kobzol @ehuss