Skip to content

Conversation

@alexcrichton
Copy link
Member

This commit now funnels all output of Cargo by default to be in target/debug
instead of the bare target directory. This change is targeted at raising
awareness of whether a debug build is being used (as opposed to a release
build). It is also aimed at remedying a common scenario where cargo build is
followed by cargo build --release and then the debug binaries are run by
accident.

This does not yet explore the option of providing symlinks to the most recent
build, hence this commit is a breaking change due to the restructuring of the
layout of the output.

Note that this commit does not change the output location for documentation.
All output of cargo doc continues to be funneled into the target/doc
directory.

Closes #785

@rust-highfive
Copy link

r? @wycats

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

cc @huonw

@huonw
Copy link
Contributor

huonw commented Mar 4, 2015

Should we try to make progress on #785 (comment) too? (Though, I suspect changing from target/binary to target/x86_64-unknown-linux-gnu/debug/binary might be an ergonomic nightmare...)

@alexcrichton
Copy link
Member Author

Hm that's a good point, I had forgotten about that. You can already get that behavior with a specified --target flag, but in general yes it's a tradeoff that we'd be burying the binaries pretty far deep down compared to where they are today!

@alexcrichton
Copy link
Member Author

@bors: r=wycats 6881fbc23d1d60452ca96d6ec1cb62c6dded548c

@bors
Copy link
Contributor

bors commented Mar 6, 2015

⌛ Testing commit 6881fbc with merge 496579a...

@bors
Copy link
Contributor

bors commented Mar 6, 2015

💔 Test failed - cargo-win-32

This commit now funnels all output of Cargo by default to be in `target/debug`
instead of the bare `target` directory. This change is targeted at raising
awareness of whether a debug build is being used (as opposed to a release
build). It is also aimed at remedying a common scenario where `cargo build` is
followed by `cargo build --release` and then the debug binaries are run by
accident.

This does not yet explore the option of providing symlinks to the most recent
build, hence this commit is a breaking change due to the restructuring of the
layout of the output.

Note that this commit does **not** change the output location for documentation.
All output of `cargo doc` continues to be funneled into the `target/doc`
directory.

Closes rust-lang#785
@alexcrichton
Copy link
Member Author

@bors: r=wycats 14ff482

bors added a commit that referenced this pull request Mar 6, 2015
This commit now funnels all output of Cargo by default to be in `target/debug`
instead of the bare `target` directory. This change is targeted at raising
awareness of whether a debug build is being used (as opposed to a release
build). It is also aimed at remedying a common scenario where `cargo build` is
followed by `cargo build --release` and then the debug binaries are run by
accident.

This does not yet explore the option of providing symlinks to the most recent
build, hence this commit is a breaking change due to the restructuring of the
layout of the output.

Note that this commit does **not** change the output location for documentation.
All output of `cargo doc` continues to be funneled into the `target/doc`
directory.

Closes #785
@bors
Copy link
Contributor

bors commented Mar 6, 2015

⌛ Testing commit 14ff482 with merge 4f9bf54...

@bors
Copy link
Contributor

bors commented Mar 6, 2015

💔 Test failed - cargo-win-32

@alexcrichton
Copy link
Member Author

@bors: retry

On Fri, Mar 6, 2015 at 11:35 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - cargo-win-32
http://buildbot.rust-lang.org/builders/cargo-win-32/builds/868


Reply to this email directly or view it on GitHub
#1373 (comment).

@bors
Copy link
Contributor

bors commented Mar 6, 2015

⚡ Previous build results for cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-64 are reusable. Rebuilding only cargo-win-32...

@bors
Copy link
Contributor

bors commented Mar 6, 2015

💔 Test failed - cargo-win-32

@alexcrichton
Copy link
Member Author

@bors: retry
On Fri, Mar 6, 2015 at 12:08 PM bors notifications@github.com wrote:

[image: 💔] Test failed - cargo-win-32
http://buildbot.rust-lang.org/builders/cargo-win-32/builds/869

Reply to this email directly or view it on GitHub
#1373 (comment).

@bors
Copy link
Contributor

bors commented Mar 6, 2015

⚡ Previous build results for cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-64 are reusable. Rebuilding only cargo-win-32...

@bors
Copy link
Contributor

bors commented Mar 6, 2015

☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32, cargo-win-64

@bors bors merged commit 14ff482 into rust-lang:master Mar 6, 2015
@alexcrichton alexcrichton deleted the issue-785 branch March 9, 2015 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Place artifacts of the default target into a subdirectory of ./target

5 participants