fix(cargo-fix): dont fix into standard library #13792
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Protect standard library source from being fixed by
cargo fix
.This is a bug in rustc, which it shouldn't have given any fix suggestion to the standard library.
However, I believe Cargo should have a layer of protection regardless it's a bug in rustc or not.
See #9857 (comment)
How should we test and review this PR?
This first commit shows the problematic behavior. The second fixes it.
The alternative idea has been brought up: only paths under workspace root are fixable.
However, it might encounter some corner cases:
#[path]
attribute pointing outside a workspace.I took this conservative approach that Cargo just stop writing into whatever pointing to sysroot.
r? ehuss