-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to rust nightly 2015-03-04 #1384
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wycats (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
⌛ Testing commit f74b404 with merge 059af53... |
💔 Test failed - cargo-mac-32 |
Hm it does indeed look like there are some more bugs to be fixed here. I think we'll need to fix the arithmetic overflows in rust master before we can land this PR. It also looks like there are some plugin changes? If you update |
I thought I can have a look in about 12 h or so after I come back from work. Cheers! |
I updated cargo to build with the 2015-03-04 rust nightly build. There seems to be some problem with benchmarking in that version, so [bench] tests failed. Otherwise, there seem to be no regressions.