Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to rust nightly 2015-03-04 #1384

Merged
merged 6 commits into from
Mar 9, 2015
Merged

Updated to rust nightly 2015-03-04 #1384

merged 6 commits into from
Mar 9, 2015

Conversation

Victor-Savu
Copy link
Contributor

I updated cargo to build with the 2015-03-04 rust nightly build. There seems to be some problem with benchmarking in that version, so [bench] tests failed. Otherwise, there seem to be no regressions.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wycats (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Member

@bors: r+ f74b404

nice!

@bors
Copy link
Contributor

bors commented Mar 5, 2015

⌛ Testing commit f74b404 with merge 059af53...

@bors
Copy link
Contributor

bors commented Mar 5, 2015

💔 Test failed - cargo-mac-32

@alexcrichton
Copy link
Member

Hm it does indeed look like there are some more bugs to be fixed here. I think we'll need to fix the arithmetic overflows in rust master before we can land this PR. It also looks like there are some plugin changes?

If you update docopt to the most recent version as well I think this PR can also knock out #1377!

@Victor-Savu
Copy link
Contributor Author

I thought docopt was at the mos recent version when I first wrote the code (24 h ago). I set every dependency to "*" and did a clean build (I also deleted ~/.cargo). I then reverted to concrete version numbers.

I can have a look in about 12 h or so after I come back from work. Cheers!

bors added a commit that referenced this pull request Mar 9, 2015
@bors bors merged commit 035c1fe into rust-lang:master Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants