Make git::use_the_cli
test truly locale independent
#13935
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
The current
git::use_the_cli
test part the output of Git but that output is locale dependant, making it fail on my non-english system.Specifically this part of the test is local-dependent:
Adding the
LC_ALL=C
env to the cargo invocation solve the issue, making the test locale independent.How should we test and review this PR?
Trying putting a different
LC_ALL
locale and the test will fail without this PR and will not fail with my PR.